Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3lcZ-00009l-Kd for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Jun 2022 21:41:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o3lcY-0006T9-HT for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Jun 2022 21:41:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3lcY-0006T0-8z for pgsql-hackers@lists.postgresql.org; Tue, 21 Jun 2022 21:41:14 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3lcV-00064Z-Kj for pgsql-hackers@postgresql.org; Tue, 21 Jun 2022 21:41:13 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id DD818FF805; Tue, 21 Jun 2022 21:41:08 +0000 (UTC) Message-ID: <4800a657-ebea-740c-5f2f-d5b096012a25@dunslane.net> Date: Tue, 21 Jun 2022 17:41:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size Content-Language: en-US To: Andres Freund Cc: Tom Lane , David Rowley , Peter Geoghegan , PostgreSQL-development , Nikita Glukhov References: <20220616233130.rparivafipt6doj3@alap3.anarazel.de> <20220617052228.mjwns6ugspihamsc@alap3.anarazel.de> <20220617062456.ahbwho67m7c3lnr3@alap3.anarazel.de> <1221363.1655476388@sss.pgh.pa.us> <20220617173055.oaqns4ty235vlyyw@alap3.anarazel.de> <20220617200605.3moq7dtxua5cxemv@alap3.anarazel.de> <018c0370-9e82-8b78-cd00-1fdea0c6811c@dunslane.net> <20220621212516.2rf4ys2sa7vingsi@alap3.anarazel.de> From: Andrew Dunstan In-Reply-To: <20220621212516.2rf4ys2sa7vingsi@alap3.anarazel.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-06-21 Tu 17:25, Andres Freund wrote: > Hi, > > On 2022-06-21 17:11:33 -0400, Andrew Dunstan wrote: >> I and a couple of colleagues have looked it over. As far as it goes the >> json fix looks kosher to me. I'll play with it some more. > Cool. > > Any chance you could look at fixing the "structure" of the generated > expression "program". The recursive ExecEvalExpr() calls are really not ok... > Yes, but I don't guarantee to have a fix in time for Beta2. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com