From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
cc: Alexander Lakhin <exclusion@gmail.com>,
 Andres Freund <andres@anarazel.de>,
        Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Noah Misch <noah@leadboat.com>,
        Jacob Champion <jacob.champion@enterprisedb.com>,
        Denis Laxalde <denis.laxalde@dalibo.com>,
        vignesh C <vignesh21@gmail.com>,
 Thomas Munro <thomas.munro@gmail.com>,
        Greg Stark <stark@mit.edu>,
        "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
        Daniel Gustafsson <daniel@yesql.se>,
        Peter Eisentraut <peter@eisentraut.org>,
        Justin Pryzby <pryzby@telsasoft.com>,
        Robert Haas <robertmhaas@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Etsuro Fujita <etsuro.fujita@gmail.com>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
In-reply-to: 
 <CAGECzQQFvsuBcT1Bu3eDWDWuxt=GT0MsGJJKK_5og51Rk-4q7Q@mail.gmail.com>
References: <202407221126.vyw5q3h4nyoh@alvherre.pgsql>
 <5ea25e4d-1ee2-b9bf-7806-119ffa658826@gmail.com>
 <578934.1725045685@sss.pgh.pa.us>
 <CAGECzQQZi_po92DSgo75vmM-KxG2zMGzo-tt+Z+85w3BgL89ug@mail.gmail.com>
 <584811.1725048717@sss.pgh.pa.us> <591893.1725051309@sss.pgh.pa.us>
 <37c3bd11-7321-fe58-99ca-bc15a67c08cc@gmail.com>
 <c68225b4-fce9-3425-1534-a21a815d5846@gmail.com>
 <colnv3lzzmc53iu5qoawynr6qq7etn47lmggqr65ddtpjliq5d@glkveb4m6nop>
 <2947163.1731810791@sss.pgh.pa.us>
 <8f280cbd-8450-87ea-f0f7-ab4932af5750@gmail.com>
 <321476.1732152654@sss.pgh.pa.us>
 <CAGECzQQFvsuBcT1Bu3eDWDWuxt=GT0MsGJJKK_5og51Rk-4q7Q@mail.gmail.com>
Comments: In-reply-to Jelte Fennema-Nio <postgres@jeltef.nl>
	message dated "Thu, 21 Nov 2024 22:33:06 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <480237.1732235854.1@sss.pgh.pa.us>
Date: Thu, 21 Nov 2024 19:37:34 -0500
Message-ID: <480238.1732235854@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/480238.1732235854%40sss.pgh.pa.us>
Precedence: bulk

Jelte Fennema-Nio <postgres@jeltef.nl> writes:
> On Thu, 21 Nov 2024 at 02:31, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This seems to fix the problem here.  Thoughts?

> Overall, a good approach to fix issue number 1. I think it would be
> best if this was integrated into libpqsrv_cancel instead though. That
> way the dblink would benefit from it too.

How would we do that?  libpqsrv_cancel is not chartered to wait around
for the results of the cancel, and I'm not even sure that it could
know what to check for.

(I did get the impression that all this code was not very well
factored, but I'm not volunteering to rewrite it wholesale.)

> nit: Maybe call it RETRY_CANCEL_TIME.

Sure.

			regards, tom lane