Feedback-ID: i131946ab:Fastmail
Message-ID: <480e3c67-b703-46ff-a418-d3b481d68372@enterprisedb.com>
Date: Wed, 22 Feb 2023 09:17:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Content-Language: en-US
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: pgindent vs. git whitespace check
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/480e3c67-b703-46ff-a418-d3b481d68372%40enterprisedb.com>
Precedence: bulk

Commit ﻿e4602483e95 accidentally introduced a situation where pgindent
disagrees with the git whitespace check.  The code is

         conn = libpqsrv_connect_params(keywords, values,
                                         /* expand_dbname = */ false,
                                        PG_WAIT_EXTENSION);

where the current source file has 4 spaces before the /*, and the
whitespace check says that that should be a tab.

I think it should actually be 3 spaces, so that the "/*..." lines up
with the "keywords..." and "PG_WAIT..." above and below.

I suppose this isn't going to be a quick fix in pgindent, but if someone
is keeping track, maybe this could be added to the to-consider list.

In the meantime, I suggest we work around this, perhaps by

         conn = libpqsrv_connect_params(keywords, values, /* expand_dbname = */ false,
                                        PG_WAIT_EXTENSION);

which appears to be robust for both camps.