public inbox for [email protected]  

help / color / mirror / Atom feed

From: Euler Taveira <[email protected]>
To: [email protected]
Cc: SATYANARAYANA NARLAPURAM <[email protected]>
Subject: Re: [Patch] Omit virtual generated columns from test_decoding output
Date: Tue, 05 May 2026 00:08:58 -0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHg+QDfTh3UbB-Ed--o2Bd=SBDJoEiG-qp3C0+ETDibF63y=dw@mail.gmail.com>
References: <CAHg+QDfTh3UbB-Ed--o2Bd=SBDJoEiG-qp3C0+ETDibF63y=dw@mail.gmail.com>

On Mon, May 4, 2026, at 10:11 PM, SATYANARAYANA NARLAPURAM wrote:
>
> Virtual generated columns are not stored on disk, so heap_getattr() in
> tuple_to_stringinfo() always returned NULL for them, producing
> misleading output such as
>
>   table public.t: INSERT: a[integer]:1 b[integer]:10 c[integer]:null
>
> even though the user could observe a non-null value via SELECT.  Stored
> generated columns continue to be emitted as before because their values
> do live in the heap tuple.
>

I wouldn't say misleading but expected. Logical decoding relies on WAL and
virtual generated columns are not stored in the WAL.

> This matches the pgoutput's logicalrep_should_publish_column()
> which never publishes virtual generated columns. Added a regression test.
> Please find the patch attached.
>

There is no guarantee that test_decoding should match the pgoutput. I agree that
test_decoding shouldn't output virtual generated columns. The problem is that it
already does it. I'm afraid that removing it should break existing applications.
(I heard that some solutions rely on test_decoding for CDC.) Should we change it
as you proposed or add an option to put it back to keep the old behavior?

I didn't review your patch but I noticed that there is a new test file for this
change. There are some concerns about the total test execution time. Do you
really need to include this test? If so, should you combine it with an existing
test file?


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [Patch] Omit virtual generated columns from test_decoding output
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox