Message-ID: <4816b2df-646f-dc19-e5cc-4bfbd04c0e43@enterprisedb.com>
Date: Fri, 28 Jan 2022 09:57:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.5.0
Subject: Re: Add header support to text format and matching feature
Content-Language: en-US
To: =?UTF-8?Q?R=c3=a9mi_Lapeyre?= <remi.lapeyre@lenstra.fr>,
 Zhihong Yu <zyu@yugabyte.com>
Cc: David Steele <david@pgmasters.net>, Michael Paquier
 <michael@paquier.xyz>, vignesh C <vignesh21@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Daniel Verite <daniel@manitou-mail.org>
References: <018819f7-6cbe-4f20-903f-de1b9e434119@manitou-mail.org>
 <9B3E4BEB-F6E2-4D4D-AFB8-58FB3957EB35@lenstra.fr>
 <29be62a4-e931-b745-3e24-7aa111963447@pgmasters.net>
 <8A231E8D-4491-4DC2-AF72-EBEAEF0F0967@lenstra.fr>
 <CALNJ-vRUVcnSO_WDJS5RRjsh26jRK2rVsPoos+xeJ4Uu1fOtWw@mail.gmail.com>
 <683DD77E-38B3-4BC2-810E-4122C7A5A053@lenstra.fr>
 <CALNJ-vRCei7pSp6-Atf3Zy3Y88UDzKEVTCxPxA4AVvUebxSfNg@mail.gmail.com>
 <8964EEB0-7AE1-4549-BA4C-119EF8CD266C@lenstra.fr>
 <94FDDB44-A608-4C75-A733-9F8FC5180D6B@lenstra.fr>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <94FDDB44-A608-4C75-A733-9F8FC5180D6B@lenstra.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/4816b2df-646f-dc19-e5cc-4bfbd04c0e43%40enterprisedb.com>
Precedence: bulk

On 31.12.21 18:36, Rémi Lapeyre wrote:
> Here’s an updated version of the patch that takes into account the changes in d1029bb5a2. The actual code is the same as v10 which was already marked as ready for committer.

I have committed the 0001 patch.  I will work on the 0002 patch next.

I notice in the 0002 patch that there is no test case for the error 
"wrong header for column \"%s\": got \"%s\"", which I think is really 
the core functionality of this patch.  So please add that.

I wonder whether the header matching should be a separate option from 
the HEADER option.  The option parsing in this patch is quite 
complicated and could be simpler if there were two separate options.  It 
appears this has been mentioned in the thread but not fully discussed.