Message-ID: <481f228c-ce59-355a-ff48-202d50d30d54@technowledgy.de>
Date: Wed, 28 Sep 2022 08:36:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
From: walther@technowledgy.de
Subject: Re: Make ON_ERROR_STOP stop on shell script failure
To: Fujii Masao <masao.fujii@oss.nttdata.com>,
 bt22nakamorit <bt22nakamorit@oss.nttdata.com>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
References: <eaf326ad693e74eba068f33a7f518039@oss.nttdata.com>
 <20220916.173035.322733707258561235.horikyota.ntt@gmail.com>
 <4c61d434cb72b2237b3279797b2a387f@oss.nttdata.com>
 <8a022f2c8de93ea79116f0b7eb42248a@oss.nttdata.com>
 <a56cb988-975d-e240-15d5-a7bd11ccc413@oss.nttdata.com>
In-Reply-To: <a56cb988-975d-e240-15d5-a7bd11ccc413@oss.nttdata.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/481f228c-ce59-355a-ff48-202d50d30d54%40technowledgy.de>
Precedence: bulk

Fujii Masao:
> One concern about this patch is that some applications already depend on
> the current behavior of ON_ERROR_STOP, i.e., psql doesn't stop even when
> the shell command returns non-zero exit code. If so, we might need to
> extend ON_ERROR_STOP so that it accepts the following setting values.

I just got bitten by this and I definitely consider this a bug. I expect 
psql to stop when a shell script fails and I have ON_ERROR_STOP set. I 
don't think this should be made more complicated with different settings.

If someone needs to have ON_ERROR_STOP set, but continue execution after 
a certain shell command, they could still do something like this:

\! might_fail || true

Best

Wolfgang