Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql1Ko-000cEk-S6 for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Sep 2023 06:14:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ql1Kn-0092Za-Cb for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Sep 2023 06:14:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql1Kn-0092ZE-14 for pgsql-hackers@lists.postgresql.org; Tue, 26 Sep 2023 06:14:13 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql1Kj-006gem-Bd for pgsql-hackers@lists.postgresql.org; Tue, 26 Sep 2023 06:14:11 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 9D1592FA8AF9 for ; Tue, 26 Sep 2023 08:13:46 +0200 (CEST) Received: from s899.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 8D0FE2E279C0; Tue, 26 Sep 2023 08:13:46 +0200 (CEST) Received: from s471.loopia.se (unknown [172.22.191.6]) by s899.loopia.se (Postfix) with ESMTP id 8AB752C8BA69; Tue, 26 Sep 2023 08:13:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s980.loopia.se ([172.22.191.5]) by s471.loopia.se (s471.loopia.se [172.22.190.35]) (amavisd-new, port 10024) with UTF8LMTP id lFhYCh8iFKuj; Tue, 26 Sep 2023 08:13:46 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s980.loopia.se (Postfix) with ESMTPSA id 350AA2201616; Tue, 26 Sep 2023 08:13:46 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set From: Daniel Gustafsson In-Reply-To: <20230925222047.GA3173226@nathanxps13> Date: Tue, 26 Sep 2023 08:13:45 +0200 Cc: bt23nguyent , Alvaro Herrera , pgsql-hackers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <482056B1-D930-417C-9473-CB1A045E42AE@yesql.se> References: <202309151049.dmfsxc5b3wyf@alvherre.pgsql> <7035FAFE-7E91-4B31-AA72-75EE82DB3F7B@yesql.se> <20230915143827.GA1912920@nathanxps13> <85b9e69997bbd5d8302a3a99a2de246d@oss.nttdata.com> <18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com> <20230925222047.GA3173226@nathanxps13> To: Nathan Bossart X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 26 Sep 2023, at 00:20, Nathan Bossart = wrote: >=20 > On Thu, Sep 21, 2023 at 11:18:00AM +0900, bt23nguyent wrote: >> -basic_archive_configured(ArchiveModuleState *state) >> +basic_archive_configured(ArchiveModuleState *state, char = **logdetail) >=20 > Could we do something more like GUC_check_errdetail() instead to = maintain > backward compatibility with v16? We'd still need something exported to call into which isn't in 16, so it wouldn't be more than optically backwards compatible since a module = written for 17 won't compile for 16, or am I missing something? -- Daniel Gustafsson