Date: Mon, 12 May 2008 21:08:05 +0200
From: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
Subject: Re: bloated heapam.h
In-reply-to: <20080512161350.GM5655@alvh.no-ip.org>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Pg Hackers <pgsql-hackers@postgresql.org>
Message-id: <48289595.7050708@sun.com>
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=us-ascii
Content-transfer-encoding: 7BIT
References: <20080509185610.GJ5748@alvh.no-ip.org> <48258C7C.9030103@sun.com>
	<20080510192615.GA9094@alvh.no-ip.org>
	<6911.1210453845@sss.pgh.pa.us>
	<20080511044745.GC9136@alvh.no-ip.org> <21641.1210531438@sss.pgh.pa.us>
	<20080512000642.GB5746@alvh.no-ip.org>
	<20080512002153.GC5746@alvh.no-ip.org>
	<20080512002853.GD5746@alvh.no-ip.org> <48283673.2080304@sun.com>
	<20080512161350.GM5655@alvh.no-ip.org>
User-Agent: Thunderbird 2.0.0.12 (X11/20080325)

Alvaro Herrera napsal(a):
> Zdenek Kotala wrote:
>> Alvaro Herrera wrote:
> 
>>> (Digging further, it seems like bufpage.h should also include transam.h
>>> in order to get TransactionIdIsNormal ... I start to wonder how many
>>> problems of this nature we have on our headers.  Without having a way to
>>> detect whether the defined macros are valid, it seems hard to check
>>> programatically, however.)
>> I attached script which should check it. In first step it runs C 
>> preprocessor on each header (postgres.h is included as well). The output 
>> from first step is processed again with preprocessor and define.h is 
>> included. Define.h contains "all" used macros in following format:
>>
>> #define SIGABRT "NOT_EXPANDED_SIGABRT"
>>
>> Main problem is how to generate define.h. I used following magic:
>>
>> grep "^#define" `find . -name "*.h"` | cut -d" "  -f 2 | cut -f 1 | cut -f 1 -d"("
>>
>> but it generates some noise as well. Maybe some Perl or AWK magic should be better.
> 
> So were you able to detect anything bogus with this technique?
> 

No, everything looks OK.

		Zdenek