Received: from localhost (unknown [200.46.204.184]) by developer.postgresql.org (Postfix) with ESMTP id 46B2A2E0040 for ; Mon, 12 May 2008 18:36:00 -0300 (ADT) Received: from developer.postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.184]) (amavisd-maia, port 10024) with ESMTP id 84539-01 for ; Mon, 12 May 2008 18:35:48 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from gmp-eb-inf-2.sun.com (gmp-eb-inf-2.sun.com [192.18.6.24]) by developer.postgresql.org (Postfix) with ESMTP id F12882E003A for ; Mon, 12 May 2008 18:35:47 -0300 (ADT) Received: from fe-emea-10.sun.com (gmp-eb-lb-2-fe2.eu.sun.com [192.18.6.11]) by gmp-eb-inf-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m4CLZkH9019250 for ; Mon, 12 May 2008 21:35:46 GMT Received: from conversion-daemon.fe-emea-10.sun.com by fe-emea-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0K0R00J01YMTTY00@fe-emea-10.sun.com> (original mail from Zdenek.Kotala@Sun.COM) for pgsql-hackers@postgresql.org; Mon, 12 May 2008 22:35:45 +0100 (BST) Received: from [192.168.2.4] ([89.103.93.253]) by fe-emea-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0K0R00LZ6YNCRCF0@fe-emea-10.sun.com>; Mon, 12 May 2008 22:35:45 +0100 (BST) Date: Mon, 12 May 2008 23:33:35 +0200 From: Zdenek Kotala Subject: Re: bloated heapam.h In-reply-to: <20080512200253.GB19344@alvh.no-ip.org> To: Alvaro Herrera Cc: Tom Lane , Pg Hackers Message-id: <4828B7AF.4030002@sun.com> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_7Vs5oL2AaMkds4J2rvbILA)" References: <20080511044745.GC9136@alvh.no-ip.org> <21641.1210531438@sss.pgh.pa.us> <20080512000642.GB5746@alvh.no-ip.org> <20080512002153.GC5746@alvh.no-ip.org> <20080512002853.GD5746@alvh.no-ip.org> <48283673.2080304@sun.com> <20080512161350.GM5655@alvh.no-ip.org> <48289595.7050708@sun.com> <20080512192656.GA19344@alvh.no-ip.org> <48289FFB.8010500@sun.com> <20080512200253.GB19344@alvh.no-ip.org> User-Agent: Thunderbird 2.0.0.12 (X11/20080325) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200805/385 X-Sequence-Number: 118384 This is a multi-part message in MIME format. --Boundary_(ID_7Vs5oL2AaMkds4J2rvbILA) Content-type: text/plain; format=flowed; charset=us-ascii Content-transfer-encoding: 7BIT Alvaro Herrera napsal(a): >> I try to play with lint now if it gets better results. > > Ok, good. Hmm, It generates a lot of unnecessary includes in *.c files. I have checked only couple of them and it seems that they are really unnecessary. A attach output. Unfortunately, it does not detect missing heapam.h from bufpage.h. However, I have not tested all magic switches yet :-). There are also several reports about system headers file, but it could be platform specific warning. Zdenek --Boundary_(ID_7Vs5oL2AaMkds4J2rvbILA) Content-type: application/x-gzip; name=include.out.gz Content-transfer-encoding: BASE64 Content-disposition: inline; filename=include.out.gz H4sICMazKEgAA2luY2x1ZGUub3V0ALUcXXPjtvHdv8KPyUPqD9k+XWb6kLaTJm3T a3NJXzkQCZE8kwQNgJZ8v767ABb8AiVIcm7mxiBF7i4Wi/0GW6F0Lrn6U/r91VXZ pFWX8ettWfHrUl13TcNTrhSTb1fX8O+b+6dvr286JW/ckzfqTd0okT5z/afCPrJ6 nDyScy1a/Ll96bh8Q0SdLqtSv8XhfFx9e93m6qW6UTL1UHUq2hsHsbjaMqVbpovI WdxNSGSyZXDRT+L+4yJOj6q4yrjSiFHynSw1/4k1WcXl4M7f+BagDm587tpWSB1H 5l2QCAfpZgKxIBS/sKZsI/lwH4HAwvPgf+W1eOWR8B8i4DuAIB7RjPkYEsIyb1gF YETLm43KEFLD91ppbrgh1Bb/qFSYP6/yAf/uymZ1j4NSlnv8W7Sd+ds15X7HpJmo 6hqhzOPpWw5v4AgwlBaFdsjgjVde4YhZUBELPJLsDYNt1GQ3yIeb7K2pBMu4hN1V MVkqFLfc0VZpoPYhEsc6tAa4ARUiYXWZJhYTbiPJuZtOVTZd5DTuH0+ahlckc7Lq UqUsq4HFMFsmHa/pVTM0qgZHPO2k0yG6rO22c0IAI4CR71JRw07FS08HXrRClftE 8ZqdqS68rPldNPoZJEHpDCU6T1RR8/pcNCDW+DRAKts00U7bHIe0Cu7rIXMB9OsJ HLgL7ThHmtlC/Txxzu8CF4bagrTEvg8jHbWOwo0QoMulsvpscPl2/Q1T1+79DAbX g0e/vfrz9N+VmQoojAbk7vvrAyR+vyAr39yvYwHMlzZlmlUip78I7uHpfHBKC8ly frM1hD18uBwSyC+Cerw7H5QxvsbiFmahQJjhBdmvHN2ogmvnHw+u3urhnbg1JiU9 g5SnpwslyaDQksU6AdPd4v21A4qapQjjZs9SsxzdtgUOGDsKe7bVVs1KkUbqq6nL 6OeScZZVoPONRdrRKGJSQas3lkaVxMNDKzqiEE0OsWimxTz5VZ0bVsQjWk2NydjW rFZLqFRrjeWp5jpkHQ4sPLHQLQY9++HQs4Y0sIZ1b57jxHIOEky3rsEBB4eiH+Ls y+Y1GnLQOhKxRmoLI7xMSmb8C5CXMhJ2kBFLVNslvY0Q1aKGSKez3qiZKsusF0RW EZ+Lnv0hZ2ZRwLxHP3e9NUMtUGfvYPTdhsG/+q01E95Gwn2Ykj6ACxrKjBAc+Liq ZWlkDPM0VY9VWZdaOWe5Kq1PBvAd5RFb/ACd9oEpk3t9AkJZAS6HMtFsYyeFF2VT GlpAPhLWGoHle57+1rWVDe8bkfEf8jyOyg9BLYEAOxDNG4JVGKg/Nxnfo1kjpL+w WG30EFQzIzyfu01bscbh+qGFAC9SJJ6CSmQ8CQvOwv6JqcgUwioY2hoHUdo/Cd+3 0sH9hcGGL6MV1HHWe4AW/o9dk+pSNLQEW7qmZf8fqzpA4X4+V4+NSBiAtET8XYou 1uc4vugWWnGlURPyX+F9CK8lydcPdUlTI+m4ICOxIG14+x9d80yYfuUKQu9IsQ7m bkaIHDiL5z9gb/CmUX6tn9xvZRa/aKvj0k7w7Ip9vjAVNeabzULhvf92VtTx9l9K sHftD7E7dhVM9o0Q9RCLAYafOGvjWfUQNLoBNB6sndlfOyl5o73scf0pUuRXQY90 zEEDrddEX4RVoj01Iz37Lrt4CnfI0k8nGLQoNJ9IH/7elC9dbBLxuOg5cAUAg8Cn q90KRYj1NJ3tLS3C/x2TZP1Sv5zA+Ijt4uAVpMRMKvtdN/sIqJ2S0aoQWF6SOxwZ OdH2nmzYZbepRoVUpAUng8hlzkm+IxK+QXtBWY82T1gtWiLj43Hm9+gphLsNGoYZ 7Qjls1sjBPQvdAbfzapbaJZD/+ZKV0LEGtTjwD1A8FwrYdOiTKVlabN26MSj22AE PuciUbzy11oZQUqiyQmqV8tNWK1UYlAju4p3tMW0ymHnldneXrzyFOg2royQNdM6 WmY/LDrP5ud1UFdZygaoiquuK2PjmQMZ9k1XVgAQw4VW8S4TGNQoylkDz+tIjs4S EKkJjyAkKJ/5kGdujTJRs9L6f+A2KfAFjevUpM7HOEM3EkYITNOKJ31yPS4dM4K1 I2BpwQbLnFDMdyFDEoCVFkPJzV2g5tlktRglZ7ykg3RWX3FqEpDZaIrrBP+3Wpyg /RfLixl47iZ5dF6s7KNPyXNKsDVg8WR5Qq5tSVrLRq/R5baSjxmhSCo/LEe02UaV X2NNfdBfmSlhYelr2EZdwEmSF5IQV460QiKZdful2PkdCxyHkM6oTUwMJR3Iz0xD ws5gjQ2Dct5QzuEMcZ4mBVClhvVazWKX6YB9HigqVMUNaeJ9rBYMZ1xnwF86YXls ZA0VFdOX7vgwf6yR69cXSXE1n8oRQBsesyqGiFcmK94wR1cXWW96OMBXC6a4ApVp ZJbrnZBGtPZ1ZDrgQzinGEg1GLn0Inl2jnUIORVcpshkYM2G8ktOIzY62h84pBFl mWhZ5jmYKfI9RBs5g9muplWPl9tgNngmt6Bjva9yBlm1bRjxKdYIjEP/K8JDDi6l aEFBgvqVN2DOgMkpwN6KsKNMdXvnC9W5BD2r7MqTleZN7J4IT3JYZHD70utTz940 Ogk3K11569iwWLsQDtVmq4GtEoUjzHmwMMI7W5txw4Q125j0DVkqm4u1qRBMKfm7 1fARUGJ+LHnlx2d4VQOboVVyAqRVkAmD+GqoacPqbri08OIp0wjuwAFyjDEZhgNg 6zZeTHZlc3f/eGeGINtNal1pcHFx8WM36mICoFSmUWhHop+K5pVwOVRAwfrpySDt 0uRLm7AmS9QX26nS6e3a3HBNLP569sAXUVjB8XcQ3LP1TRnIn7lXWwevB1OUW50A rOT+9vZh9FNXmEfTN1lWVZkOX9+U+SMRrHfmF7rlX883d+vb1e3oHnBjvX78mNzN 6PzSErw0TCjBN7Fm8AkDZjCR4fXCXC2HgtAcqTMMaTOZ5fPomrg1uunjY7MO97Se IHe3M/h6Z2dp25PqdG/dCwFqoXJFOo69GVFy+Tirs1GVjikwzrFh16LP2KoEA/4u dptMHXwPKO/OrTtOCotBDeTaDDS444qhG6W/9nEboP7OO9j91bz9o38w3LkT3fsR 9D6/uXu8rF8DNJzslOufOMMN7lsAOlCUneNOwasWvDcIQSJFbiYs3piGbe28MLxk RoekFCaspFLlZcXiMNmDirSnbNzfIn2q8H4q10O/NK/Ehllbg1V7onkLugAJiNw6 yx0bdqMfykd5TIWp6LmiLlWaMxqAbyd2rhVKNax1t1NRb0Qa6weH67CWEA8JNuCL q+2AKtPMJmu0qTBjma6/iq8s3Z6S2727DQZDYWfBBb0HEh6DpAK6x01u3GPkbUWV fbi1d2obhpSfh2HO6feNlpy7McR7jHqh4JI3Wr4Nro2nS3kbDLMb0uYIp6ue3fCV pZ11teGCIldAZJJuls9wpTi65u7C0QAj7yLBuEcAFzQRfFX4u751C4tAZvWs/mCt v8BpP/M356JiVOFqy/BExm2aqAX+aW1THy6XgjAIFnOtnBDROB62smv6R0rh4Glh 22PM3GkNlFZtVfqLnoNK96ujdHz5JFzQdPbGgyoM1OFiKE2rgWMnAxgG9Gthrhx7 zdgRhWPiNYUS+Fe8bisaE3ATWMCWp3G/jGm0DxGuOA56kTa5WSXcKmRh0XPpIOYx jX1wQX/PiMV6s1TJzqztTrQwF55I0lvU7NNtDH6DEKbn5ZeWlt7EMUSjygqZkVdL c84bO8ggxE1UI3aguSPTK2FJcHsL/iaWnIG5iQneNa+Tnz9/SqzXnGzLBthhltz8 9PtvPybrRHfy2d21J2JKa1XGb98nUtSsKa0UDV6f3R4gRL/TWYT+hRK05MLzRdfk TM5xbCUEVFO6MxaYDG/yanh3QkyXd9yu4PRXtePZHFzOZR0mNUjSlMGD5w/MOut0 GnxnGXtw7o2QO547JM5MD34OLkZ42uC/qQVipwx2YNoQQQGO//PTz+vk1xkCt6JL jJiCH/w0mnTtGr4kz7fOEsEQoq5XnvYXohLSX1V878fNlvX3fToWM+5J1v8k6pZu 7z1YLqUFurOhQZJx0x/nd26cFph6guPkcvgI2pKOOOALj/LsiT97gHrL8LjlVm/B xGyawGq0sm6jKwl/hD4zVJSeunMrwItUxFUmdn3wF7eiyxbeGIziEMfIpzRmxtaE D9A6zJUpKi7SG+uoPKs12gfWY+CtWql4a0TzFpuQ/SMWxJChC65YJ2NzCeF0X4AQ rQaqQAvgK2sij4wekuoBF9sXW3aOAzrrLBgGi6yLPXwajGjHR2jvp+ch5udTl/OW sSWZI43eUxKmYfVqGncDdUjhjU59tDY7zDCbx/Fe6GD0VpWb9uXGHEtNIb6KDTUX MyfFJvYo4KFCVvsCFipyOz7NcvejNvwPsy79CV/Wh44wb/h3WwWRyiZyS8465/vc 1Et/ZgOgmkOXkXboQ1DOBxK0nmVuRixYT1kwssjrI20+h9apzh7j98iS8CEQkL6q o2D13J5xlBnWZJjlNEVQL/kHjzD151Mg2ABtVrO0zmI1cHBPeToG4Ezxr6RDBizP wS1hmhOqLtoYhznpUXbWWmInDsE2ZveEOQUN1ix/bMU9aB2GZW+TTMHJU+B/iT59 LfnuXbhkABFVFftqa6ewZd5sgw3KRMViG+XCGXePzANDQ2xsc/xihBkcMvFO5FNb X7ONaics+mF+TUBi92ZbRR9MCe+SvqIOO2OYRj76nQP6OgQoDdFG+jHLFiucc5nb 1+AkRh0ekmNxS5gTeqZYRfwXLQiAUvHLEe4D98sBcZnkuAlbySmJmfkPZJxxSnRk EFZTj8i1XNBRGJoGwxRkHML1opPFKqf0kQKCbA5j+ZNl5uoE3oVtwyCqGFuHx+ML 61qzKSFOtCj+0vEm9vjbwTypO/6LK+xa7rMNLXfkJjtsxg9WBR32DBsPZOZsxj7+ KzCzzeUkJhVKU88i8Kp8NdvA7Ag5xID947B5XDdvFo/4IbjWvWZBSMo4FwwMo3If Fakqex8VPQye+ZsiKk6Y8zTN4eac8xeRpHubS4Wh2N/7cdvf5nL4yJ0fU/bHPl8P Xog/lTvd3ZPy48L2tug7bVUYoSUNa+lxDX9x/aeHaFgQGEtDdLdsOD3UL38PzoGW HAtwZTOeI8gFT+lOnI9/FGsP02ppTVWwc8+j9PAVRCMGugNNdUQcowxT/QqvQQlE Tyvoagz2EoDDqLgpsYIUfbgmLivmg9yIXEMqOXjORAL+pU3Tc+ZdxGfIaC+2Ue6u GWxP0NxRUHGqTXSIFFT4iyeOHuJ4jyQwe/DZSzTqzCb6METY0xyrbAOtOLQbZoS9 stj46YiYW2cUrFH8lMLHVpanFI6wDneYhnN9ISGRPIv/vtHR1SBoyJIBVRd4PHPr jEqLoDpLfYmrN0DgNkzhmkZt1VvaAueVHc2/T2QfCDY4xX91J9zg9HR7/sdxfBe8 hXR/KSQ66wLM6bWB2c7xlYHw6fOhVEoP30dHl1WRwFvbCRntFS+lvixNTpUNI39z nxoG7BVpAnuF3Etjv9DxeDRB4uERTXYH9PjMiYQLVFu9waDHdt8e/CCNowrF31bT iivfBWJH84ZA+0D4Q1Cry/ZK/IekFhKuhnvxx+DCWYrx2ROcruuZcOCZdJ0ro0Me cQjjilltTu0wZxv9wUdzLLDiynespLYnr2bx2ddZPnqWLFlP/fvxl7A+Hms9SwV4 scInsO/uDn9oiD4OaD51ByBcImzHqsEkzbnc+JU5kg2a6pVWVJ7ccFv/LIO6FfI5 weSgOx8ZoRSD1nqwvCOQxLxpOOg+uMU6LU5Jy348+rEnyqJjzNgfA2WgT8yI/EWO AYv//RU/fmLr9MweRnRfYTG/bszXDlwnuC4ze22jG3fsTHT9aeuaPXN/gYAUQT7l LNc0/+yCUyNmGadv5pizEZSjYmmVFs84ojY8eJrO+FiBxg/JOZJNRv7StA4et0Pt IzZfXMRjaeNN+uawUnOfJWBwevncKgBt0X7u5ogKc91lw6ZRmqY7bg4/jRgG1z0r 6VgMrjH2LEYfUQ8HZESlh2WY5WsuCPr/nUobiaxZAAA= --Boundary_(ID_7Vs5oL2AaMkds4J2rvbILA)--