Message-ID: <482DA66B.4000901@dunslane.net>
Date: Fri, 16 May 2008 11:21:15 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Merlin Moncure <mmoncure@gmail.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Chernow <ac@esilo.com>,
	Alvaro Herrera <alvherre@commandprompt.com>,
	"Patches (PostgreSQL)" <pgsql-patches@postgresql.org>
Subject: Re: libpq object hooks
References: <b42b73150804301323i18b00019i62e765708abb65aa@mail.gmail.com>	
	<b42b73150805150852m7b3c28fai2d7a4497c84118b2@mail.gmail.com>	
	<6044.1210867771@sss.pgh.pa.us> <482C77E5.1060500@esilo.com>	
	<9458.1210875556@sss.pgh.pa.us> <482C82BA.3090100@esilo.com>	
	<9867.1210877054@sss.pgh.pa.us> <482CD76E.6000202@esilo.com>	
	<b42b73150805160628y3c175608hc383187951206448@mail.gmail.com>	
	<17177.1210949948@sss.pgh.pa.us>
	<b42b73150805160813x7fba1ccaif0c7d28cc2d53f4d@mail.gmail.com>
In-Reply-To: <b42b73150805160813x7fba1ccaif0c7d28cc2d53f4d@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Merlin Moncure wrote:
>   
>> Also, even if varargs are safe they'd be notationally unpleasant
>> in the extreme.  varargs are just a PITA to work with --- you'd have
>> to do all the decoding in the first-level hook routine, even for
>> items you weren't going to use.  With something like the above
>> all you need is a switch() and some pointer casts.
>>     
>
> Switch, plus struct (basically a union) will do the trick nicely.  Can
> it be a formal union, or is it better as a void*?
>
> The main issue was how what we called the 'hook data' was passed back
> and forth.  We'll get a patch up.
>
>
>   

All of this is getting quite a long way from what was in the commitfest 
queue. Do we still want to try to get this in this cycle, or should it 
be marked returned to author for more work?

cheers

andrew