agora inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Chernow <[email protected]>
To: Tom Lane <[email protected]>
Cc: Merlin Moncure <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Patches (PostgreSQL) <[email protected]>
Subject: Re: libpq object hooks
Date: Fri, 16 May 2008 20:00:07 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Tom Lane wrote:
> Where
> exactly does the hook hand off the storage pointer to libpq?  What
> are you going to do if the hook fails to create the storage
> (ie, out of memory during PGresult creation)?

The current submitted patch has 3 of its function callbacks returning a 
void*, initHookData after the creation of a conn, resultCreate, and 
resultCopy.  We have recently changed this design so all hooks, now 
called events, go through a single callback ... PGEventProc.  The old 
function callbacks are just eventIds now.

/////////////////////////////////
// The libpq side (looping registered event procs)
PGEventResultCreate info;
info.stateData = NULL; /* our event data ptr */
info.conn = conn;
info.result = result;

if(!result->evtState[i].proc(PGEVT_RESULTCREATE,
   (void *)&info, result->evtState[i].passThrough)
{
   PQclear(result); // destroy result? ... not sure
   return error;    // previously, we ignored it
}

// assign event data created by event proc.
result->evtState[i].data = info.stateData;


///////////////////////////////////////
// example of what the event proc does
int my_evtproc(PGEventId evtId, void *evtInfo, void *passThrough)
{
   switch(eventId)
   {
     case PGEVT_RESULTCREATE:
     {
       void *data = makeresultdata(....)
       if(!data)
         return FALSE;
       ((PGEventResultCreate *)evtInfo)->stateData = data;
       break;
     }
   }

   return TRUE;
}


-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

-- 
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

view thread (64+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: libpq object hooks
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox