Subject: Re: Add support for automatically updating Unicode derived files
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <c8d05f42-443e-6c23-819b-05b31759a37c@2ndquadrant.com>
 <CACPNZCv2jmjpqkatr-NBJ8wpP6trY8MPBbW8nhqi--hL-0+dgQ@mail.gmail.com>
 <ff2f8e99-ac2b-1940-81c5-8b2fd1e674e7@2ndquadrant.com>
 <CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com>
 <acc8396a-4e06-e5d4-6d42-f710eef11ede@2ndquadrant.com>
 <26652.1579048650@sss.pgh.pa.us>
 <02d8b722-8c60-d039-ca00-7b74f09ff657@2ndquadrant.com>
 <10754.1579535012@sss.pgh.pa.us>
Cc: John Naylor <john.naylor@2ndquadrant.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <482c7eea-6ffa-32cc-68a5-76e7eb44ee4c@2ndquadrant.com>
Date: Fri, 24 Jan 2020 12:25:06 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <10754.1579535012@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-01-20 16:43, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> On 2020-01-15 01:37, Tom Lane wrote:
>>> This patch is making src/tools/pginclude/headerscheck unhappy:
>>> ./src/include/common/unicode_combining_table.h:3: error: array type has incomplete element type
> 
>> Hmm, this file is only meant to be included inside one particular
>> function.  Making it standalone includable would seem to be unnecessary.
>>    What should we do?
> 
> Well, we could make it a documented exception in headerscheck and
> cpluspluscheck.

OK, done.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services