Received: from localhost (unknown [200.46.204.183]) by developer.postgresql.org (Postfix) with ESMTP id E510E2E0032 for ; Sun, 18 May 2008 11:33:22 -0300 (ADT) Received: from developer.postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 87642-09 for ; Sun, 18 May 2008 11:33:14 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.esilo.com (ns1.esilo.com [63.150.152.211]) by developer.postgresql.org (Postfix) with ESMTP id A09BD2E002F for ; Sun, 18 May 2008 11:33:19 -0300 (ADT) Received: from [192.168.1.103] (c-65-34-212-214.hsd1.fl.comcast.net [65.34.212.214]) (authenticated bits=0) by mail.esilo.com (8.13.1/8.13.1) with ESMTP id m4IEXAld009381; Sun, 18 May 2008 10:33:13 -0400 Message-ID: <48303E34.20305@esilo.com> Date: Sun, 18 May 2008 10:33:24 -0400 From: Andrew Chernow User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Merlin Moncure CC: Tom Lane , Andrew Dunstan , Alvaro Herrera , "Patches (PostgreSQL)" Subject: Re: libpq object hooks (libpq events) References: <482A58D8.2030205@dunslane.net> <20080514043313.GS6966@alvh.no-ip.org> <482AD896.4000504@dunslane.net> <19342.1210776271@sss.pgh.pa.us> <482B1480.1070705@esilo.com> <482B2AC5.7000503@esilo.com> <482ECF62.7010901@esilo.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200805/367 X-Sequence-Number: 6393 Merlin Moncure wrote: > On Sat, May 17, 2008 at 8:28 AM, Andrew Chernow wrote: >> Here is an updated patch for what was called object hooks. This is now >> called libpq events. If someone has a better name or hates ours, let us >> know. > > > Let's decide where to go with this. We have no objections to pushing > this back to the next fest (tom's comments on the wiki were noted). > If that's the case though, we would like to wrap up a consenus on the > general implementation in the meantime. Just give us a heads up and > I'll update the wiki. > > merlin > > Yeah, it would be nice to avoid another push back into July by getting some feedback now for June; it would be great to squeeze it into May. I'm not talking about a review, but maybe a couple of "I hate this" or "This works well" or "Give up coding" :) The implementation of the events (as well as when they were object hooks) is actually very simple, so a quick glance can probably raise most concerns. There is very little going on. In the end, something like this can be done several different ways (choice here is a matter of taste & style). It would be nice to iron out the API and focus on other aspects; namely is this general concept appealing enough. -- Andrew Chernow eSilo, LLC every bit counts http://www.esilo.com/