Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uK6Vn-00Drsf-43 for pgsql-hackers@arkaria.postgresql.org; Wed, 28 May 2025 02:27:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uK6Vl-00DMxe-4T for pgsql-hackers@arkaria.postgresql.org; Wed, 28 May 2025 02:27:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uK6Vk-00DMxR-85 for pgsql-hackers@lists.postgresql.org; Wed, 28 May 2025 02:27:20 +0000 Received: from mail-m16.yeah.net ([1.95.21.14]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uK6Vd-000TUu-0q for pgsql-hackers@postgresql.org; Wed, 28 May 2025 02:27:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Content-Type:Message-ID:Date:MIME-Version:Subject: To:From; bh=YmjNQQE0EzSTqAIbNaE62ZYBHv8I565IfpqR3WEUPDc=; b=TfQH mFTV2uCi4OwdwlGiL7xK0kJ9Rh09Qel+bI7h74AQVqf+viA6O8vsel8XtiP6gaXi rLUAuxa5eiUgb/yAe5ZtRQcZDPE1X0dpSA5IAfMbi1zbv4wMcre1ILmENkhVI6uz FykmSHbMSZCapLDU1fOABsPPn1obiCbRC/lUntY= Received: from [192.168.10.60] (unknown []) by gzsmtp3 (Coremail) with SMTP id M88vCgDXE8RydDZo097oAQ--.23731S2; Wed, 28 May 2025 10:26:58 +0800 (CST) Content-Type: multipart/mixed; boundary="------------f4ACbisdQr65Tmr5ZYYWb1yF" Message-ID: <483ea517-4812-47b8-856b-3f7d0d15ed4e@yeah.net> Date: Wed, 28 May 2025 10:26:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Standardize the definition of the subtype field of AlterDomainStmt To: Michael Paquier Cc: pgsql-hackers References: <41ff310b-16bd-44b9-a3ef-97e20f14b709@yeah.net> Content-Language: en-US From: Quan Zongliang In-Reply-To: X-CM-TRANSID: M88vCgDXE8RydDZo097oAQ--.23731S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrZFyxuFyUJw4kCrWrWrW5Awb_yoWkGFbE9r WIkr1xtw1DCFykJa18Gw4ayFZxurWj9r17Jrn8XF93XrZ8XFs3GrsY9r97Zr1fXF4rtFnx uFyqyw1YyF9xujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0TE_PUUUUU== X-Originating-IP: [117.13.75.128] X-CM-SenderInfo: htxd06xrqjzxxdqjq5hhdkh0dhw/1tbiNBThBmg2dHSl9wAA3L List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------f4ACbisdQr65Tmr5ZYYWb1yF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/5/27 11:54, Michael Paquier wrote: > On Tue, May 27, 2025 at 11:06:46AM +0800, Quan Zongliang wrote: >> I noticed that the subtype of AlterDomainStmt is directly using constants in >> the code. It is not conducive to the maintenance and reading of the code. >> Based on the definition of AlterTableType, use "AD_" as the prefix. Define >> several macros to replace the original characters. >> The subtype of AlterTableCmd is defined using an enumeration. The subtypes >> of AlterDomainStmt are relatively few in number, and the original definition >> uses characters. These definitions still use characters and maintain the >> values unchanged. If some plugins or tools are also processing >> AlterDomainStmt, there will be no errors. > > Sounds like a good idea. As far as I can see after a closer lookup at > the tree, you have updated all the code paths that matter for this > change, and you have added a CF entry: > https://commitfest.postgresql.org/patch/5780/ > > +#define AD_VaidateConstraint 'V' /* VALIDATE CONSTRAINT */ > Updated Thank you. > s/Vaidate/Validate > -- > Michael --------------f4ACbisdQr65Tmr5ZYYWb1yF Content-Type: text/plain; charset=UTF-8; name="alterdomain_subtype.patch" Content-Disposition: attachment; filename="alterdomain_subtype.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2Jh Y2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggNTRhZDM4MjQ3YWEuLjNmMDlmODVh NDgwIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYworKysg Yi9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYwpAQCAtMTU2OTYsNyArMTU2OTYs NyBAQCBBVFBvc3RBbHRlclR5cGVQYXJzZShPaWQgb2xkSWQsIE9pZCBvbGRSZWxJZCwgT2lk IHJlZlJlbElkLCBjaGFyICpjbWQsCiAJCXsKIAkJCUFsdGVyRG9tYWluU3RtdCAqc3RtdCA9 IChBbHRlckRvbWFpblN0bXQgKikgc3RtOwogCi0JCQlpZiAoc3RtdC0+c3VidHlwZSA9PSAn QycpCS8qIEFERCBDT05TVFJBSU5UICovCisJCQlpZiAoc3RtdC0+c3VidHlwZSA9PSBBRF9B ZGRDb25zdHJhaW50KQogCQkJewogCQkJCUNvbnN0cmFpbnQgKmNvbiA9IGNhc3ROb2RlKENv bnN0cmFpbnQsIHN0bXQtPmRlZik7CiAJCQkJQWx0ZXJUYWJsZUNtZCAqY21kID0gbWFrZU5v ZGUoQWx0ZXJUYWJsZUNtZCk7CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wYXJzZXIvZ3Jh bS55IGIvc3JjL2JhY2tlbmQvcGFyc2VyL2dyYW0ueQppbmRleCAwYjU2NTIwNzFkMS4uMTAz MDIxYzA5NDcgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9ncmFtLnkKKysrIGIv c3JjL2JhY2tlbmQvcGFyc2VyL2dyYW0ueQpAQCAtMTE2MjksNyArMTE2MjksNyBAQCBBbHRl ckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0bXQgKm4gPSBtYWtlTm9k ZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUgPSAnVCc7CisJCQkJCW4t PnN1YnR5cGUgPSBBRF9BbHRlckRlZmF1bHQ7CiAJCQkJCW4tPnR5cGVOYW1lID0gJDM7CiAJ CQkJCW4tPmRlZiA9ICQ0OwogCQkJCQkkJCA9IChOb2RlICopIG47CkBAIC0xMTYzOSw3ICsx MTYzOSw3IEBAIEFsdGVyRG9tYWluU3RtdDoKIAkJCQl7CiAJCQkJCUFsdGVyRG9tYWluU3Rt dCAqbiA9IG1ha2VOb2RlKEFsdGVyRG9tYWluU3RtdCk7CiAKLQkJCQkJbi0+c3VidHlwZSA9 ICdOJzsKKwkJCQkJbi0+c3VidHlwZSA9IEFEX0Ryb3BOb3ROdWxsOwogCQkJCQluLT50eXBl TmFtZSA9ICQzOwogCQkJCQkkJCA9IChOb2RlICopIG47CiAJCQkJfQpAQCAtMTE2NDgsNyAr MTE2NDgsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0 bXQgKm4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUg PSAnTyc7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9TZXROb3ROdWxsOwogCQkJCQluLT50eXBl TmFtZSA9ICQzOwogCQkJCQkkJCA9IChOb2RlICopIG47CiAJCQkJfQpAQCAtMTE2NTcsNyAr MTE2NTcsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0 bXQgKm4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUg PSAnQyc7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9BZGRDb25zdHJhaW50OwogCQkJCQluLT50 eXBlTmFtZSA9ICQzOwogCQkJCQluLT5kZWYgPSAkNTsKIAkJCQkJJCQgPSAoTm9kZSAqKSBu OwpAQCAtMTE2NjcsNyArMTE2NjcsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJ CQlBbHRlckRvbWFpblN0bXQgKm4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0J CQkJCW4tPnN1YnR5cGUgPSAnWCc7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9Ecm9wQ29uc3Ry YWludDsKIAkJCQkJbi0+dHlwZU5hbWUgPSAkMzsKIAkJCQkJbi0+bmFtZSA9ICQ2OwogCQkJ CQluLT5iZWhhdmlvciA9ICQ3OwpAQCAtMTE2NzksNyArMTE2NzksNyBAQCBBbHRlckRvbWFp blN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0bXQgKm4gPSBtYWtlTm9kZShBbHRl ckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUgPSAnWCc7CisJCQkJCW4tPnN1YnR5 cGUgPSBBRF9Ecm9wQ29uc3RyYWludDsKIAkJCQkJbi0+dHlwZU5hbWUgPSAkMzsKIAkJCQkJ bi0+bmFtZSA9ICQ4OwogCQkJCQluLT5iZWhhdmlvciA9ICQ5OwpAQCAtMTE2OTEsNyArMTE2 OTEsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0bXQg Km4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUgPSAn Vic7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9WYWxpZGF0ZUNvbnN0cmFpbnQ7CiAJCQkJCW4t PnR5cGVOYW1lID0gJDM7CiAJCQkJCW4tPm5hbWUgPSAkNjsKIAkJCQkJJCQgPSAoTm9kZSAq KSBuOwpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdGNvcC91dGlsaXR5LmMgYi9zcmMvYmFj a2VuZC90Y29wL3V0aWxpdHkuYwppbmRleCAyNWZlM2Q1ODAxNi4uYWZmODUxMDc1NWYgMTAw NjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3Rjb3AvdXRpbGl0eS5jCisrKyBiL3NyYy9iYWNrZW5k L3Rjb3AvdXRpbGl0eS5jCkBAIC0xMzQzLDcgKzEzNDMsNyBAQCBQcm9jZXNzVXRpbGl0eVNs b3coUGFyc2VTdGF0ZSAqcHN0YXRlLAogCQkJCQkgKi8KIAkJCQkJc3dpdGNoIChzdG10LT5z dWJ0eXBlKQogCQkJCQl7Ci0JCQkJCQljYXNlICdUJzoJLyogQUxURVIgRE9NQUlOIERFRkFV TFQgKi8KKwkJCQkJCWNhc2UgQURfQWx0ZXJEZWZhdWx0OgogCiAJCQkJCQkJLyoKIAkJCQkJ CQkgKiBSZWN1cnNpdmVseSBhbHRlciBjb2x1bW4gZGVmYXVsdCBmb3IgdGFibGUgYW5kLApA QCAtMTM1MywzMCArMTM1MywzMCBAQCBQcm9jZXNzVXRpbGl0eVNsb3coUGFyc2VTdGF0ZSAq cHN0YXRlLAogCQkJCQkJCQlBbHRlckRvbWFpbkRlZmF1bHQoc3RtdC0+dHlwZU5hbWUsCiAJ CQkJCQkJCQkJCQkgICBzdG10LT5kZWYpOwogCQkJCQkJCWJyZWFrOwotCQkJCQkJY2FzZSAn Tic6CS8qIEFMVEVSIERPTUFJTiBEUk9QIE5PVCBOVUxMICovCisJCQkJCQljYXNlIEFEX0Ry b3BOb3ROdWxsOgogCQkJCQkJCWFkZHJlc3MgPQogCQkJCQkJCQlBbHRlckRvbWFpbk5vdE51 bGwoc3RtdC0+dHlwZU5hbWUsCiAJCQkJCQkJCQkJCQkgICBmYWxzZSk7CiAJCQkJCQkJYnJl YWs7Ci0JCQkJCQljYXNlICdPJzoJLyogQUxURVIgRE9NQUlOIFNFVCBOT1QgTlVMTCAqLwor CQkJCQkJY2FzZSBBRF9TZXROb3ROdWxsOgogCQkJCQkJCWFkZHJlc3MgPQogCQkJCQkJCQlB bHRlckRvbWFpbk5vdE51bGwoc3RtdC0+dHlwZU5hbWUsCiAJCQkJCQkJCQkJCQkgICB0cnVl KTsKIAkJCQkJCQlicmVhazsKLQkJCQkJCWNhc2UgJ0MnOgkvKiBBREQgQ09OU1RSQUlOVCAq LworCQkJCQkJY2FzZSBBRF9BZGRDb25zdHJhaW50OgogCQkJCQkJCWFkZHJlc3MgPQogCQkJ CQkJCQlBbHRlckRvbWFpbkFkZENvbnN0cmFpbnQoc3RtdC0+dHlwZU5hbWUsCiAJCQkJCQkJ CQkJCQkJCSBzdG10LT5kZWYsCiAJCQkJCQkJCQkJCQkJCSAmc2Vjb25kYXJ5T2JqZWN0KTsK IAkJCQkJCQlicmVhazsKLQkJCQkJCWNhc2UgJ1gnOgkvKiBEUk9QIENPTlNUUkFJTlQgKi8K KwkJCQkJCWNhc2UgQURfRHJvcENvbnN0cmFpbnQ6CiAJCQkJCQkJYWRkcmVzcyA9CiAJCQkJ CQkJCUFsdGVyRG9tYWluRHJvcENvbnN0cmFpbnQoc3RtdC0+dHlwZU5hbWUsCiAJCQkJCQkJ CQkJCQkJCSAgc3RtdC0+bmFtZSwKIAkJCQkJCQkJCQkJCQkJICBzdG10LT5iZWhhdmlvciwK IAkJCQkJCQkJCQkJCQkJICBzdG10LT5taXNzaW5nX29rKTsKIAkJCQkJCQlicmVhazsKLQkJ CQkJCWNhc2UgJ1YnOgkvKiBWQUxJREFURSBDT05TVFJBSU5UICovCisJCQkJCQljYXNlIEFE X1ZhbGlkYXRlQ29uc3RyYWludDoKIAkJCQkJCQlhZGRyZXNzID0KIAkJCQkJCQkJQWx0ZXJE b21haW5WYWxpZGF0ZUNvbnN0cmFpbnQoc3RtdC0+dHlwZU5hbWUsCiAJCQkJCQkJCQkJCQkJ CQkgIHN0bXQtPm5hbWUpOwpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvbm9kZXMvcGFyc2Vu b2Rlcy5oIGIvc3JjL2luY2x1ZGUvbm9kZXMvcGFyc2Vub2Rlcy5oCmluZGV4IDQ2MTBmYzYx MjkzLi42ZWIxOWVlYjJkZSAxMDA2NDQKLS0tIGEvc3JjL2luY2x1ZGUvbm9kZXMvcGFyc2Vu b2Rlcy5oCisrKyBiL3NyYy9pbmNsdWRlL25vZGVzL3BhcnNlbm9kZXMuaApAQCAtMjUzNCwx NCArMjUzNCw3IEBAIHR5cGVkZWYgc3RydWN0IEFsdGVyQ29sbGF0aW9uU3RtdAogdHlwZWRl ZiBzdHJ1Y3QgQWx0ZXJEb21haW5TdG10CiB7CiAJTm9kZVRhZwkJdHlwZTsKLQljaGFyCQlz dWJ0eXBlOwkJLyotLS0tLS0tLS0tLS0KLQkJCQkJCQkJICoJVCA9IGFsdGVyIGNvbHVtbiBk ZWZhdWx0Ci0JCQkJCQkJCSAqCU4gPSBhbHRlciBjb2x1bW4gZHJvcCBub3QgbnVsbAotCQkJ CQkJCQkgKglPID0gYWx0ZXIgY29sdW1uIHNldCBub3QgbnVsbAotCQkJCQkJCQkgKglDID0g YWRkIGNvbnN0cmFpbnQKLQkJCQkJCQkJICoJWCA9IGRyb3AgY29uc3RyYWludAotCQkJCQkJ CQkgKi0tLS0tLS0tLS0tLQotCQkJCQkJCQkgKi8KKwljaGFyCQlzdWJ0eXBlOwkJLyogc2Vl IEFEX3h4eCBjb25zdGFudHMgYmVsb3cgKi8KIAlMaXN0CSAgICp0eXBlTmFtZTsJCS8qIGRv bWFpbiB0byB3b3JrIG9uICovCiAJY2hhcgkgICAqbmFtZTsJCQkvKiBjb2x1bW4gb3IgY29u c3RyYWludCBuYW1lIHRvIGFjdCBvbiAqLwogCU5vZGUJICAgKmRlZjsJCQkvKiBkZWZpbml0 aW9uIG9mIGRlZmF1bHQgb3IgY29uc3RyYWludCAqLwpAQCAtMjU0OSw2ICsyNTQyLDEzIEBA IHR5cGVkZWYgc3RydWN0IEFsdGVyRG9tYWluU3RtdAogCWJvb2wJCW1pc3Npbmdfb2s7CQkv KiBza2lwIGVycm9yIGlmIG1pc3Npbmc/ICovCiB9IEFsdGVyRG9tYWluU3RtdDsKIAorLyog QWx0ZXJEb21haW5TdG10IGFjdGlvbiAqLworI2RlZmluZSBBRF9BbHRlckRlZmF1bHQJCQkJ J1QnCQkJLyogU0VUfERST1AgREVGQVVMVCAqLworI2RlZmluZSBBRF9Ecm9wTm90TnVsbAkJ CQknTicJCQkvKiBEUk9QIE5PVCBOVUxMICovCisjZGVmaW5lIEFEX1NldE5vdE51bGwJCQkJ J08nCQkJLyogU0VUIE5PVCBOVUxMICovCisjZGVmaW5lIEFEX0FkZENvbnN0cmFpbnQJCQkn QycJCQkvKiBBREQgQ09OU1RSQUlOVCAqLworI2RlZmluZSBBRF9Ecm9wQ29uc3RyYWludAkJ CSdYJwkJCS8qIERST1AgQ09OU1RSQUlOVCAqLworI2RlZmluZSBBRF9WYWxpZGF0ZUNvbnN0 cmFpbnQJCSdWJwkJCS8qIFZBTElEQVRFIENPTlNUUkFJTlQgKi8KIAogLyogLS0tLS0tLS0t LS0tLS0tLS0tLS0tLQogICoJCUdyYW50fFJldm9rZSBTdGF0ZW1lbnQK --------------f4ACbisdQr65Tmr5ZYYWb1yF--