From: Tom Lane <tgl@sss.pgh.pa.us>
To: James Hilliard <james.hilliard1@gmail.com>
cc: pgsql-hackers@lists.postgresql.org,
        Sergey Shinderuk <s.shinderuk@postgrespro.ru>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Re: [PATCH v2 1/1] Fix detection of pwritev support for OSX.
In-reply-to: <20210119165435.45411-1-james.hilliard1@gmail.com>
References: <20210119165435.45411-1-james.hilliard1@gmail.com>
Comments: In-reply-to James Hilliard <james.hilliard1@gmail.com>
	message dated "Tue, 19 Jan 2021 09:54:35 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <484262.1611077376.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Jan 2021 12:29:36 -0500
Message-ID: <484263.1611077376@sss.pgh.pa.us>
Precedence: bulk

James Hilliard <james.hilliard1@gmail.com> writes:
> Fixes:
> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newe=
r [-Wunguarded-availability-new]

It's still missing preadv, and it still has nonzero chance of breaking
successful detection of pwritev on platforms other than yours, and it's
still really ugly.

But the main reason I don't want to go this way is that I don't think
it'll stop with preadv/pwritev.  If we make it our job to build
successfully even when using the wrong SDK version for the target
platform, we're going to be in for more and more pain with other
kernel APIs.

We could, of course, do what Apple wants us to do and try to build
executables that work across versions.  I do not intend to put up
with the sort of invasive, error-prone source-code-level runtime test
they recommend ... but given that there is weak linking involved here,
I wonder if there is a way to silently sub in src/port/pwritev.c
when executing on a pre-11 macOS, by dint of marking it a weak
symbol?

			regards, tom lane