Message-ID: <484823C6.6030207@pse-consulting.de>
Date: Thu, 05 Jun 2008 19:35:02 +0200
From: Andreas Pflug <pgadmin@pse-consulting.de>
User-Agent: Thunderbird 2.0.0.14 (Windows/20080421)
MIME-Version: 1.0
To: Greg Smith <gsmith@gregsmith.com>
CC: Magnus Hagander <magnus@hagander.net>,
	Heikki Linnakangas <heikki@enterprisedb.com>,
	Alvaro Herrera <alvherre@commandprompt.com>, pgsql-hackers@postgresql.org
Subject: Re: Overhauling GUCS
References: <48409D1E.3070208@agliodbs.com>
	<200806010032.53337.peter_e@gmx.net>
	<Pine.GSO.4.64.0806020452220.26912@westnet.com>
	<17932.1212415926@sss.pgh.pa.us>
	<20080604131810.GH65238@decibel.org>
	<4846A483.8000001@pse-consulting.de>
	<Pine.GSO.4.64.0806041045520.2258@westnet.com>
	<29525.1212613052@sss.pgh.pa.us> <48472E47.7030701@dunslane.net>
	<Pine.GSO.4.64.0806042033120.3874@westnet.com>
	<20080605162400.GF16502@alvh.no-ip.org>
	<48481CBF.6040602@enterprisedb.com> <48481E3A.4010306@hagander.net>
	<Pine.GSO.4.64.0806051321360.27711@westnet.com>
In-Reply-To: <Pine.GSO.4.64.0806051321360.27711@westnet.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Greg Smith wrote:
> On Thu, 5 Jun 2008, Magnus Hagander wrote:
>
>> We really need a "proper API" for it, and the stuff in pgAdmin isn't 
>> even enough to base one on.
>
> I would be curious to hear your opinion on whether the GUC overhaul 
> discussed in this thread is a useful precursor to building such a 
> proper API.

Since I'm the guy who initially wrote that config file editing stuff, I 
feel somehow addressed.
The answer is a clear ABSOLUTELY.

- The current implementation is able to edit the file directly or 
through pgsql functions; any format change will affect that function 
immediately.
- If documentation is enhanced by adding more comments in the 
postgresql.conf file, this won't help the editor because it can't rely 
on it to present help and hints to the user. It needs the comments/help 
in pg_settings or alike.


Regards,
Andreas