Received: from localhost (unknown [200.46.204.183]) by developer.postgresql.org (Postfix) with ESMTP id 0CD362E0039 for ; Fri, 6 Jun 2008 08:45:44 -0300 (ADT) Received: from developer.postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 09309-01 for ; Fri, 6 Jun 2008 08:45:24 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by developer.postgresql.org (Postfix) with ESMTP id 729062E003D for ; Fri, 6 Jun 2008 08:45:28 -0300 (ADT) Received: from pse.dyndns.org (p548F1B4E.dip0.t-ipconnect.de [84.143.27.78]) by mrelayeu.kundenserver.de (node=mrelayeu2) with ESMTP (Nemesis) id 0MKwtQ-1K4aNo2rpT-0004SU; Fri, 06 Jun 2008 13:45:25 +0200 Received: from [192.168.0.2] (helo=[192.168.0.2]) by pse.dyndns.org with esmtp (Exim 4.44) id 1K4aNn-00039k-KG; Fri, 06 Jun 2008 13:45:23 +0200 Message-ID: <48492356.4040506@pse-consulting.de> Date: Fri, 06 Jun 2008 13:45:26 +0200 From: Andreas Pflug User-Agent: Thunderbird 2.0.0.14 (Windows/20080421) MIME-Version: 1.0 To: Gregory Stark CC: pgsql-hackers@postgresql.org Subject: Re: Overhauling GUCS References: <29525.1212613052@sss.pgh.pa.us> <48472E47.7030701@dunslane.net> <20080605162400.GF16502@alvh.no-ip.org> <48481CBF.6040602@enterprisedb.com> <48481E3A.4010306@hagander.net> <20080605174209.GL16502@alvh.no-ip.org> <20080605212129.GI14498@yugib.highrise.ca> <3F927D52-A0FD-4575-8D24-F0F70C459235@kineticode.com> <4848FAA6.8000903@pse-consulting.de> <87ej7aeuqx.fsf@oxford.xeocode.com> <4849137C.3040008@pse-consulting.de> <877id2erp6.fsf@oxford.xeocode.com> In-Reply-To: <877id2erp6.fsf@oxford.xeocode.com> X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX1/N9ihNBBAX1go9v52sXZ56SOqTKXtR/kP6K73 SfPbhMlojBKIXP3cGSrC9/4lG9FsZSS6XCzdJ5BPWLEe/L+/HO +57u69XDEzyRu7SIHHgZA== X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200806/274 X-Sequence-Number: 119387 Gregory Stark wrote: > So all you have is our existing file except with an additional layer of > quoting to deal with, a useless SET keyword to annoy users, and a file that > you need a bison parser Don't you think that's a little over the top, throwing bison at the simple task to extend postgresql.conf scanning so it accepts --, /**/ and SET? > to deal instead of a simple keyword-value syntax that > sed can manipulate. > > sed seems to be THE killer application... Apart from the fact that sed easily could identify SET, my answer would be to use psql to modify the config, not sed. Text config files are NOT friendly for beginner and mediocre users. IMHO the current restriction on GUC changes is a major obstacle towards pgsql tuning tools, e.g. written as a Google SoC project. Graphic tools aren't too popular at pgsql-hackers, but please contemplate a little how much pgadmin may have contributed to the pgsql usage boost, esp. on windows. Regards, Andreas