public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Greg Sabino Mullane <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: Logging which interface was connected to in log_line_prefix
Date: Sun, 12 May 2024 14:21:15 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAKAnmmK-U+UicE-qbNU23K--Q5XTLdM6bj+gbkZBZkjyjrd3Ow@mail.gmail.com>
References: <CAKAnmmK-U+UicE-qbNU23K--Q5XTLdM6bj+gbkZBZkjyjrd3Ow@mail.gmail.com>

On 06.03.24 16:59, Greg Sabino Mullane wrote:
> Someone on -general was asking about this, as they are listening on 
> multiple IPs and would like to know which exact one clients were 
> hitting. I took a quick look and we already have that information, so I 
> grabbed some stuff from inet_server_addr and added it as part of a "%L" 
> (for 'local interface'). Quick patch / POC attached.

I was confused by this patch title.  This feature does not log the 
interface (like "eth0" or "lo"), but the local address.  Please adjust 
the terminology.

I noticed that for Unix-domain socket connections, %r and %h write 
"[local]".  I think that should be done for this new placeholder as well.

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Logging which interface was connected to in log_line_prefix
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox