From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org, David Fetter <david@fetter.org>,
        Stephen Frost <sfrost@snowman.net>,
        PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: New EXPLAIN option: ALL
In-reply-to: <1A90C4C3-861A-4B2A-B263-702CC1AA6C8C@anarazel.de>
References: <20190507163411.GM28936@fetter.org>
 <20190507164430.a7tig676hjzdnyyd@alap3.anarazel.de>
 <20190507212355.GQ28936@fetter.org>
 <20190507215449.3a4yb5kkoloq7yyw@alap3.anarazel.de>
 <4638.1557266803@sss.pgh.pa.us> <20190507221255.GO6197@tamriel.snowman.net>
 <5221.1557267912@sss.pgh.pa.us> <20190513055112.GA24409@fetter.org>
 <20190515060214.GZ28936@fetter.org> <30903.1557927151@sss.pgh.pa.us>
 <20190515142033.GB28936@fetter.org>
 <1A90C4C3-861A-4B2A-B263-702CC1AA6C8C@anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 15 May 2019 07:29:26 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4858.1557931599.1@sss.pgh.pa.us>
Date: Wed, 15 May 2019 10:46:39 -0400
Message-ID: <4859.1557931599@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On May 15, 2019 7:20:34 AM PDT, David Fetter <david@fetter.org> wrote:
>> Indeed. I think we should move our regression tests to TAP and
>> dispense with this.

> -inconceivably much

Yeah, that's not happening.

Just eyeing the patch again, it seems like most of the test-output churn
is from a decision to make printing of planner options be on-by-default;
which is also what creates the buildfarm-variant-options hazard.  So
I suggest reconsidering that.  TBH, even without the regression test
angle, I suspect that such a change would receive a lot of pushback.
It's a pretty big delta in the verbosity of EXPLAIN, and it is frankly
of no value to a lot of people a lot of the time.

			regards, tom lane