From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
cc: Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>,
        Thomas Munro <thomas.munro@gmail.com>
Subject: Pointer subtraction with a null pointer
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <48825.1648310694.1@sss.pgh.pa.us>
Date: Sat, 26 Mar 2022 12:04:54 -0400
Message-ID: <48826.1648310694@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/48826.1648310694%40sss.pgh.pa.us>
Precedence: bulk

Several of Andres' buildfarm animals have recently started to whine
that "performing pointer subtraction with a null pointer has undefined
behavior" for assorted places in freepage.c.

From a mathematical standpoint, this astonishes me: "x - 0 = x" is a
tautology.  So I'm a bit inclined to say "you're full of it" and disable
-Wnull-pointer-subtraction.  On the other hand, all of the occurrences
are in calls of relptr_store with a constant-NULL third argument.
So we could silence them without too much pain by adjusting that macro
to special-case NULL.  Or maybe we should change these call sites to do
something different, because this is surely abusing the intent of
relptr_store.

Thoughts?

			regards, tom lane