Message-ID: <48969cff-0a9a-448d-947a-e92898ccc57a@uni-muenster.de>
Date: Mon, 5 Feb 2024 15:43:55 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Patch: Add parse_type Function
Content-Language: en-US
To: "David E. Wheeler" <david@justatheory.com>
Cc: pgsql-hackers@lists.postgresql.org,
 Pavel Stehule <pavel.stehule@gmail.com>
References: <DF2324CA-2673-4ABE-B382-26B5770B6AA3@justatheory.com>
 <c1f10523-1d0c-4bf2-b45d-1b903a9315d2@uni-muenster.de>
 <E42E9A97-B07E-4DB6-A34F-D9E5F7A8EF22@justatheory.com>
From: Jim Jones <jim.jones@uni-muenster.de>
In-Reply-To: <E42E9A97-B07E-4DB6-A34F-D9E5F7A8EF22@justatheory.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/48969cff-0a9a-448d-947a-e92898ccc57a%40uni-muenster.de>
Precedence: bulk


On 05.02.24 15:10, David E. Wheeler wrote:
> Excellent, thank you very much! Updated patch attached.
>
> Best,
>
> David

v2 no longer crashes with a null parameter.
docs and regress tests were updated accordingly.

patch no longer applies cleanly (tiny little indentation issue):

/home/jim/Downloads/v2-0001-Add-parse_type-SQL-function.patch:140:
indent with spaces.
        PG_RETURN_NULL();
warning: 1 line adds whitespace errors.

I read the comments again, and something is not entirely clear to me.
Line 494 says "Raises an error on an invalid type." and 501 says
"Returns NULL for an invalid type."
Perhaps merging both comment blocks and rephrasing these sentences would
make things clearer?

-- 
Jim