Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 6D2B564FFB2 for ; Wed, 3 Sep 2008 14:12:16 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 17872-08 for ; Wed, 3 Sep 2008 14:12:09 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.esilo.com (ns1.esilo.com [63.150.152.211]) by postgresql.org (Postfix) with ESMTP id 4291E65014C for ; Wed, 3 Sep 2008 14:12:08 -0300 (ADT) Received: from [10.0.0.2] (fwext-esilo-jupiter.esilo.com [64.135.45.146]) (authenticated bits=0) by mail.esilo.com (8.13.1/8.13.1) with ESMTP id m83HC4Jr016847; Wed, 3 Sep 2008 13:12:04 -0400 Message-ID: <48BEC5DB.7000601@esilo.com> Date: Wed, 03 Sep 2008 13:14:03 -0400 From: Andrew Chernow User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Alvaro Herrera CC: Merlin Moncure , Pg Hackers Subject: Re: libpq object hooks (libpq events) References: <482B1480.1070705@esilo.com> <482B2AC5.7000503@esilo.com> <482ECF62.7010901@esilo.com> <12200.1211242959@sss.pgh.pa.us> <48323593.4060302@esilo.com> <13642.1211251078@sss.pgh.pa.us> <48323F94.6010201@esilo.com> <48325386.2010506@esilo.com> <20080903001920.GT12610@alvh.no-ip.org> <48BE0424.4080905@esilo.com> <20080903165544.GA4114@alvh.no-ip.org> In-Reply-To: <20080903165544.GA4114@alvh.no-ip.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200809/200 X-Sequence-Number: 123329 Alvaro Herrera wrote: > Andrew Chernow escribió: >> Alvaro Herrera wrote: > >>> (I also removed PQresultAlloc.) >> Nooooooo ... removing PQresultAlloc breaks libpqtypes! It also removes >> some of the use cases provided by PQsetvalue, which allows one to add to >> a result (in our case from scratch). > > I don't really see the point -- it's the same as pqResultAlloc, except > that you have to pass an extra argument. There's no actual > functionality loss. > libpqtypes uses it. libpqtypes doesn't have access to any internals of libpq, including pqResultAlloc. So, I made a public wrapper to the internal version. The point is to provide public access to the result allocator. -- Andrew Chernow eSilo, LLC every bit counts http://www.esilo.com/