Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFhXw-005S8j-2J for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 00:03:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wFhXu-00FlXG-2M for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 00:03:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFhXu-00FlX8-1P for pgsql-hackers@lists.postgresql.org; Thu, 23 Apr 2026 00:03:54 +0000 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wFhXs-00000002YWs-0TK1 for pgsql-hackers@lists.postgresql.org; Thu, 23 Apr 2026 00:03:54 +0000 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-82fa01e86e2so3227822b3a.0 for ; Wed, 22 Apr 2026 17:03:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776902629; x=1777507429; darn=lists.postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UiVcJTHRvxRg3pO/hE6pFA4QNG+CMgK/p+Cw1ag48C0=; b=OJ1lxRr9r1NXDf9RgL0ejznoBk4zLTqBG+2H5eODrE/waetBXZL3ymaJ+cr+Mau/wf DR/0EQreshsJdcXdwqhKqVdybMnz/6LULUUVt2IipM0hm+1S4OnjoVXMt2YcruJA4zva FshtILSIw49RgvWVQKiIayUrioLhajA+5KvDkteISyGz6MfevJQ9NAVQh8KFLxRkCvoQ NWk4XydVBoG9IZysuY094WQO1Acaci4qXuMydVlVVbomQEvvmVLO8dSVFhc/fTU2a/0+ 9kYuKwQw8zwJr4ia1zUb/znr5UzKRAU2QFAZMsC30sbc3yGi7XfNdVTPSx3y2LD9bvKP dGkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776902629; x=1777507429; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UiVcJTHRvxRg3pO/hE6pFA4QNG+CMgK/p+Cw1ag48C0=; b=RelNd+/GrV8iitVxKee6Y3TdKBwKePoxCIcea2jj4CpL2fAle0k11j1H+g9Fw7it3J gpFa9B5bQySObusrOz2mIxzn4h/bZMesoHGBRpAa/4EFVQ8BStyDQGFLUDNXHEEwC7uS nIc9uViMkfX6+MB66eDTTZrS6ZmB55vCbIjwEUC8HQHsldfZb3Mp5+0eVFXiWT9Gxg0D RhSfVaAhkQxbZ2Mg/c7f3HWgXaX96fiU6rLwPj+U2G3N5chMbaSzpvIicXu2zxXM9DHu V0PQdBixj+eCPorYlN0zt5gaOaewuAUWufoWhVn152m1IAUJIKuG//FFZ1kRQp8TufQ2 28HQ== X-Gm-Message-State: AOJu0Yx3qqaqdPGZ33Yi4HygsXQ+13jAWxl8cOpUjp/701/Z4jW8Rf24 xy9VLD5GNydfZE0dGdNAxF7G3imDGNVnJv3kCwLVkQ2RA6GAyuaKln7g X-Gm-Gg: AeBDieuUMwqGwfLJLyZSNt5YW/s/Y+LHWAahWXIgzdtFCDdJIiAk2VhsNxx/+WftqlY 2THLwFyKkZoKj0yEr/3gKE/o20aIPDJwk+MHhdeU/vk+alvoJ+rOtUY1Rs0csQ1eNybOqIoBobG Z8TpGX+o4ISKN24xvP1jEjE/7kHq2Ks6cW9n0OLA5V4WYH+4p/6iQkncrwHzGXMI5E9SMxAcOWC BM2a2wCLSbarhpn1Tt9CztFiOlVBgn4QnamHZeoPx++/hjXMRRchtYFOfwE/obw+172UsodeTzv H4UrGOm3BVUVE7KhQSM6Mu7UcEBvyFh20q5Dk23X0Yq9g4AU7xQx0NBGoYmRIE1fpxNn1I3hp8W 3WiCDK4EdpFtB4jQSh+/vBK0sXbDc7G9cRl/35gPkWGllgbtSupcSQYnP/q4eYRhC7mzYkIQpdn +7MO0aeIjEDNugaZfg//mJvmF/K/tez8VN4CdDVlct+A== X-Received: by 2002:a05:6a00:1c96:b0:82f:1d38:f692 with SMTP id d2e1a72fcca58-82f8c7db39dmr25058417b3a.6.1776902629004; Wed, 22 Apr 2026 17:03:49 -0700 (PDT) Received: from smtpclient.apple ([45.32.121.103]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ec06cbfsm21391691b3a.58.2026.04.22.17.03.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Apr 2026 17:03:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: Add null check on get_tablespace_name() return in pg_get_database_ddl_internal From: Chao Li In-Reply-To: Date: Thu, 23 Apr 2026 08:03:08 +0800 Cc: PostgreSQL Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <48F28858-660B-4A70-90D2-C4FF45D9E341@gmail.com> References: To: SATYANARAYANA NARLAPURAM X-Mailer: Apple Mail (2.3864.400.21) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Apr 23, 2026, at 06:20, SATYANARAYANA NARLAPURAM = wrote: >=20 > Hi Hackers, >=20 > A concurrent tablespace drop could lead to null deref in = pg_get_database_ddl. I acknowledge this is a corner case. Adding a patch = to fix this to keep the code clean. >=20 > Thanks, > Satya > = <0001-Fix-NULL-deref-in-pg_get_database_ddl-on-concurrent-tablespace-drop.= patch> This is a dup of my recent patch, see [1]. [1] = https://www.postgresql.org/message-id/573E45C1-31A4-4885-A00C-1A2171159A2A= %40gmail.com Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/