Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZvHK-00AKgg-S0 for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Jul 2025 17:41:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uZvHI-00FVOZ-Ut for pgsql-hackers@arkaria.postgresql.org; Thu, 10 Jul 2025 17:41:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uZvHI-00FVOR-LD for pgsql-hackers@lists.postgresql.org; Thu, 10 Jul 2025 17:41:49 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uZvHG-006sdM-2e for pgsql-hackers@lists.postgresql.org; Thu, 10 Jul 2025 17:41:48 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-60780d74c85so1664315a12.2 for ; Thu, 10 Jul 2025 10:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752169305; x=1752774105; darn=lists.postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RAmHUfl1tcK93Vw1lOd07vV0RWJ2Xdhil9Zwjou7+HY=; b=TrKZBIiWv/wg6Unlt9ogPjT6rBhjMz/OpRcmwi4Nz4ClCrs5vwldvdoGn7JBc/AZcX oeTzqamGnHu5MyX6sbx1ObnDbPt2KrtjQIeGGdElvA3ETG2sHVIqwQaS4xdLnSPaFmyy figeTpAqUnle8pRwcKPvmNKD5hUwruQDDstjgUhTvdoHkXVC35wQgZ6ht+sPX8ogOUoQ I5l7zJVRv9fszD6BguJouIFrWjqqGalnEqpcYhkcZ7sOy4x5AeapVn2vyuFV3q6j+Yo/ nfskPzsRb4TnCd/DTf5B4GQedLwhfbxd9Oz4+m48I8FMdFZ7Ac1EdSN+vX8VYG5s+6Tb 2M2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752169305; x=1752774105; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RAmHUfl1tcK93Vw1lOd07vV0RWJ2Xdhil9Zwjou7+HY=; b=RmowH+tnyifnfGu2IL/166Yt+xazJR/MZAX6OSeY3oc2rLSjFryWBBY3bSH7t1Zx/h d0i//tV4DPQUaDaZQIOD/qObVht/8oHvLs5DYbEF/fhFdRNOzjxQ2ohB/3Ub1aumQqq1 2zt6V7OwTU+vPy2WqevhRU0kjlVO0iIg/MQFIWZM82dnXZMHIZAH024qu2RL1fFdTCni Xm97INM9iQ3vweYTsmZfntxEMOdg5PUrP31UmBSksC4ECza+fKeY/W1gD3HdR6ZbMr8l r8YxdMNn78KqkLWG5F7PgiRaSLc1L/7x4BNrD60FDBdvA4t+dsPdiLvJhJeVoXj79Lvs SFEQ== X-Forwarded-Encrypted: i=1; AJvYcCWy4T4Z+qsLQecz2gx18ScTY3RMyWeMj/m0xcdS4qvTMXPGeSKHUKJtKFoHQxoiOTXGaL17lQX+UpKqxCd0@lists.postgresql.org X-Gm-Message-State: AOJu0YwHi1S8awwJSwp9d1FO6Nx5OR7dgLjfaqMoIeH9hJu3TgSph8eN Gytg3ff33PCZf1dJqsCt80LEfv2K9k7OYWkmTuQr7pUlkc/EtFKziTbY X-Gm-Gg: ASbGnct7bE4Cgvug6Q6D4kQ/jw2KQQWcXhJ7erpLfSLW8/RdICHm21HoHkVXPh9+6sy SEjaO4T8nOuK846Pa4yvw34Plz6ohrHkghs8RrO273R9lEgvIExTfJN7dKH1eq8SSjqYntT+jjH 18cvs74zK+Qx6DEPTFwCiBoQnsZIyFo0NBWqpwa25V3gs5vnTdH+rfr6w5oDVzYk/EG0zHESnzX 0d6TNPfd2ehl7xKpiBYYwCy45PAS7Cyv7W2Bc61sJy2YoBkAkOVFW8M/XAIMgyFQ+UMtbktEkCB ZX13J4O5fQyKq+8f98QwyiXLhzbSDHfcj20WQuwa8TYXelYKTl2zql5/rzEa29H2NTo9GPwJ9Ya mf0mpuhqOt0NG4rsjf0gEwDKU6J27PJReiGaj3MqNtzOqZ5jaDSNX X-Google-Smtp-Source: AGHT+IHV4I6EFqaId3fI/u1DGnBd22DXSlr2l2weMPXAVt+Pmbd1elY1mNV750ZPaHCiTw66KN6Wvg== X-Received: by 2002:a05:6402:205c:b0:60e:b01:74c1 with SMTP id 4fb4d7f45d1cf-611a748a89cmr5831653a12.31.1752169304405; Thu, 10 Jul 2025 10:41:44 -0700 (PDT) Received: from smtpclient.apple (adsl-123.176.58.227.tellas.gr. [176.58.227.123]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-611c95232d8sm1146415a12.18.2025.07.10.10.41.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jul 2025 10:41:43 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part From: Florents Tselai In-Reply-To: Date: Thu, 10 Jul 2025 20:41:11 +0300 Cc: Tom Lane , Peter Eisentraut , Robert Haas , Alexander Korotkov , pgsql-hackers , Andrew Dunstan Content-Transfer-Encoding: quoted-printable Message-Id: <4904EA5B-C6CA-42BD-BF08-C89325240C9D@gmail.com> References: <145894.1727298237@sss.pgh.pa.us> <7e9debe6-4e96-4b0d-a801-b531e962ef43@eisentraut.org> <01DC1C38-0692-461B-AA63-5394330356BE@gmail.com> <2568904.1748022721@sss.pgh.pa.us> <40912112-7FFE-400F-A38F-368827C4BDF1@gmail.com> <176C517D-2DEB-4CAB-9AE4-261079D313B9@justatheory.com> <8FD5F4CF-9059-40C1-9F0A-C3CBA8DFE17A@justatheory.com> <696ECBBC-3CBF-4522-AE66-E48225688E93@gmail.com> <59C63857-406D-4704-A1EB-9BF3AA639C86@justatheory.com> <06FA8975-2E21-46A5-B510-028B3B967EB2@justatheory.com> <2F58E05D-D319-4CD3-8805-E1A8A2482A1A@justatheory.com> <4A96ACDB-78A1-4434-8C25-7C9716A7D421@justatheory.com> To: "David E. Wheeler" X-Mailer: Apple Mail (2.3826.600.51.1.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 14 Jun 2025, at 6:08=E2=80=AFPM, David E. Wheeler = wrote: >=20 > On Jun 4, 2025, at 11:27, David E. Wheeler = wrote: >=20 >> And these should fix the CI failure. I also ran pgindent. >=20 > Here=E2=80=99s a quick rebase. I think it=E2=80=99s ready for = committer review, but since I=E2=80=99ve poked at it quite a bit myself, = I updated the Commitfest item [1] to =E2=80=9CNeeds Review=E2=80=9D. >=20 > Best, >=20 > David >=20 > [1]: https://commitfest.postgresql.org/patch/5270/ >=20 > = >=20 The basic problem I see with these latest revisions/refactorings is that = they fail for pg_upgrade afaict. Probably this means that some of the rearrangements on the = parser/scanner are not that flexible.=20=