Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 41BDE64FF0F for ; Tue, 28 Oct 2008 14:10:24 -0300 (ADT) Received: from postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 22128-05 for ; Tue, 28 Oct 2008 14:10:22 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173]) by postgresql.org (Postfix) with ESMTP id 0D76164FED3 for ; Tue, 28 Oct 2008 14:10:21 -0300 (ADT) Received: by ug-out-1314.google.com with SMTP id k40so333178ugc.7 for ; Tue, 28 Oct 2008 10:10:20 -0700 (PDT) Received: by 10.210.46.4 with SMTP id t4mr8613634ebt.166.1225213820666; Tue, 28 Oct 2008 10:10:20 -0700 (PDT) Received: from ?88.195.116.231? (dsl-hkibrasgw2-ff74c300-231.dhcp.inet.fi [88.195.116.231]) by mx.google.com with ESMTPS id h6sm9922147nfh.21.2008.10.28.10.10.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 28 Oct 2008 10:10:19 -0700 (PDT) Message-ID: <49074779.2080309@enterprisedb.com> Date: Tue, 28 Oct 2008 19:10:17 +0200 Organization: EnterpriseDB User-Agent: Mozilla-Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: Tom Lane CC: PostgreSQL-development Subject: Re: Updating FSM on recovery References: <49072021.7010801@enterprisedb.com> <24334.1225205478@sss.pgh.pa.us> In-Reply-To: <24334.1225205478@sss.pgh.pa.us> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit From: Heikki Linnakangas X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200810/1425 X-Sequence-Number: 126442 Tom Lane wrote: > As far as the ugliness in XLogRecordPageWithFreeSpace goes: couldn't you > just call XLogReadBufferWithFork with init = true, and then initialize > the page if PageIsNew? With init=true, we don't even try to read the page from the disk (since 8.3), so all FSM pages accessed during recovery would be zeroed out. I don't think that's what you intended. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com