Message-ID: <49199F08.8050302@hagander.net>
Date: Tue, 11 Nov 2008 16:04:40 +0100
From: Magnus Hagander <magnus@hagander.net>
User-Agent: Thunderbird 2.0.0.17 (X11/20080925)
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: PG Hackers <pgsql-hackers@postgresql.org>
Subject: Re: libpq with ssl vs psql without
References: <49198742.2060906@hagander.net> <15027.1226410828@sss.pgh.pa.us>
In-Reply-To: <15027.1226410828@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> I just noticed that if you have libpq with SSL support, but psql
>> without, we don't print any SSL information at all. Would it be
>> worthwhile to have it print that SSL is in use, even if we can't print
>> the details about the connection?
> 
> I think the use-case for this is nonexistent, but you can still sell the
> change on the grounds of reducing the number of #ifdefs.
> 
> It might be worth putting a comment in there, because people will wonder
> what the heck this is about.
> 
> 	/* this can only happen if libpq has SSL support and psql doesn't */

Done.

//Magnus