Message-ID: <491dba16-55df-d5fd-1ae7-01b5140987f0@joeconway.com>
Date: Thu, 6 Oct 2022 07:33:46 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: use has_privs_of_role() for pg_hba.conf
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>,
 Nathan Bossart <nathandbossart@gmail.com>
Cc: Joshua Brindle <joshua.brindle@crunchydata.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <20220401220648.GA615994@nathanxps13>
 <CAGB+Vh5epaDEu7aRokcuc_a7yG0B49u9ebpdViJHpyFN-exJtQ@mail.gmail.com>
 <20220404142551.GB663209@nathanxps13> <Yz6NRrfd7n2AXoHh@paquier.xyz>
From: Joe Conway <mail@joeconway.com>
In-Reply-To: <Yz6NRrfd7n2AXoHh@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/491dba16-55df-d5fd-1ae7-01b5140987f0%40joeconway.com>
Precedence: bulk

On 10/6/22 04:09, Michael Paquier wrote:
> On Mon, Apr 04, 2022 at 07:25:51AM -0700, Nathan Bossart wrote:
>> On Mon, Apr 04, 2022 at 09:36:13AM -0400, Joshua Brindle wrote:
>>> Good catch, I think this is a logical followup to the previous
>>> has_privs_of_role patch.
>>> 
>>> Reviewed and +1
>> 
>> Thanks!  I created a commitfest entry for this:
> 
> This patch looks simple, but it is a very sensitive area so I think
> that we should be really careful.  pg_hba.conf does not have a lot of
> test coverage, so I'd really prefer if we add something to see the
> difference of behavior and check the behavior that we are switching
> here.

Agreed

> Joe, you are registered as a reviewer and committer of this patch, by
> the way.  Are you planning to look at it?

I am meaning to get to it, but as you say wanted to spend some time to 
understand the nuances and life keeps getting in the way. I will try to 
prioritize it over the next week.

Joe
-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com