Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id D69F464FE35 for ; Thu, 20 Nov 2008 10:58:47 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 87102-01 for ; Thu, 20 Nov 2008 10:58:45 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from svr2.hagander.net (svr2.hagander.net [88.198.128.226]) by mail.postgresql.org (Postfix) with ESMTP id 16EA164FE2D for ; Thu, 20 Nov 2008 10:58:45 -0400 (AST) Received: from dynamic.hagander.net ([127.0.0.1]) (encrypted and authenticated) by svr2.hagander.net (Postfix) with ESMTP id BD0C1DCCE9D for ; Thu, 20 Nov 2008 15:58:42 +0100 (CET) Received: from [127.0.0.1] (localhost [127.0.0.1]) by mha-laptop.hagander.net (Postfix) with ESMTP id 5A9AE124121 for ; Thu, 20 Nov 2008 15:58:42 +0100 (CET) Message-ID: <49257B22.6070005@hagander.net> Date: Thu, 20 Nov 2008 15:58:42 +0100 From: Magnus Hagander User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: PG Hackers Subject: Error arguments in pl_exec.c X-Enigmail-Version: 0.95.0 Content-Type: multipart/mixed; boundary="------------030008080200000602080004" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200811/1349 X-Sequence-Number: 128061 This is a multi-part message in MIME format. --------------030008080200000602080004 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I get the following warnings in HEAD pl_exec.c: In function ‘exec_stmt_raise’: pl_exec.c:2538: warning: format not a string literal and no format arguments pl_exec.c:2538: warning: format not a string literal and no format arguments Attached patch seems right to me - objections? //Magnus --------------030008080200000602080004 Content-Type: text/x-diff; name="plexec.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="plexec.diff" Index: pl_exec.c =================================================================== RCS file: /cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v retrieving revision 1.224 diff -c -r1.224 pl_exec.c *** pl_exec.c 5 Nov 2008 00:07:54 -0000 1.224 --- pl_exec.c 20 Nov 2008 14:58:11 -0000 *************** *** 2538,2545 **** ereport(stmt->elog_level, (err_code ? errcode(err_code) : 0, errmsg_internal("%s", err_message), ! (err_detail != NULL) ? errdetail(err_detail) : 0, ! (err_hint != NULL) ? errhint(err_hint) : 0)); estate->err_text = NULL; /* un-suppress... */ --- 2538,2545 ---- ereport(stmt->elog_level, (err_code ? errcode(err_code) : 0, errmsg_internal("%s", err_message), ! (err_detail != NULL) ? errdetail("%s", err_detail) : 0, ! (err_hint != NULL) ? errhint("%s", err_hint) : 0)); estate->err_text = NULL; /* un-suppress... */ --------------030008080200000602080004--