Received: from localhost (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id A4F9464FC4E
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Wed,  3 Dec 2008 04:46:22 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 62527-10
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Wed,  3 Dec 2008 04:46:20 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.27])
	by mail.postgresql.org (Postfix) with ESMTP id 0F30B64FC9D
	for <pgsql-hackers@postgresql.org>;
	Wed,  3 Dec 2008 04:46:18 -0400 (AST)
Received: by ey-out-2122.google.com with SMTP id 6so1545644eyi.61
	for <pgsql-hackers@postgresql.org>;
	Wed, 03 Dec 2008 00:46:17 -0800 (PST)
Received: by 10.210.58.17 with SMTP id g17mr15115612eba.130.1228293977528;
	Wed, 03 Dec 2008 00:46:17 -0800 (PST)
Received: from ?80.223.223.193? (dsl-hkibrasgw2-fedfdf00-193.dhcp.inet.fi
	[80.223.223.193])
	by mx.google.com with ESMTPS id f3sm7555015nfh.2.2008.12.03.00.46.01
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Wed, 03 Dec 2008 00:46:16 -0800 (PST)
Message-ID: <49364748.4060402@enterprisedb.com>
Date: Wed, 03 Dec 2008 10:46:00 +0200
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.17 (X11/20081018)
MIME-Version: 1.0
To: Emmanuel Cecchet <manu@frogthinker.org>
CC: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Subject: Re: Transactions and temp tables
References: <48EA7B12.6050906@frogthinker.org>
	<48EB0551.50205@enterprisedb.com> <48EB95B7.10604@frogthinker.org>
	<48EC7EB5.5020001@enterprisedb.com>
	<48ECAA8F.3070306@frogthinker.org> <28137.1223472191@sss.pgh.pa.us>
	<48ECBBC2.6060003@frogthinker.org> <29132.1223475486@sss.pgh.pa.us>
	<48EFA13C.2060407@frogthinker.org>
	<490F804A.60108@enterprisedb.com> <490FB4B3.908@frogthinker.org>
	<49106B10.2090407@enterprisedb.com>
	<4910DFC0.3080301@frogthinker.org>
	<4914CD14.2060608@frogthinker.org>
	<4921C42A.3030600@enterprisedb.com>
	<492221A3.1060608@frogthinker.org>
	<4922A798.7050709@enterprisedb.com>
	<49232993.1050801@enterprisedb.com>
	<49243376.2000404@frogthinker.org>
	<492543D5.9050904@enterprisedb.com>
	<492B377F.4080602@frogthinker.org>
	<49344E22.2000008@frogthinker.org>
In-Reply-To: <49344E22.2000008@frogthinker.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200812/128
X-Sequence-Number: 128757

Emmanuel Cecchet wrote:
> I think that the Assert in is_temp_rel(Oid) in tablecmds.c should be 
> replaced by if (on_commits == NULL) return false;
> As the use case below shows, a regular table can be created and hold a 
> LOCKTAG_RELATION lock that will trigger the call to is_temp_rel in 
> is_preparable_locktag. The assert will break if no temp table was accessed.

Yes, you're right.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com