Content-Type: text/plain; charset="iso-8859-15"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: Add standard collation UNICODE
From: "Daniel Verite" <daniel@manitou-mail.org>
To: "Peter Eisentraut" <peter.eisentraut@enterprisedb.com>
Cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
In-Reply-To: <1293e382-2093-a2bf-a397-c04e8f83d3c2@enterprisedb.com>
Date: Thu, 27 Apr 2023 13:44:55 +0200
Message-Id: <49417853-7bdd-4b23-a4e9-04c7aff33821@manitou-mail.org>
Archived-At: <https://www.postgresql.org/message-id/49417853-7bdd-4b23-a4e9-04c7aff33821%40manitou-mail.org>
Precedence: bulk

	Peter Eisentraut wrote:

>      COLLATE UNICODE
>=20
> instead of
>=20
>      COLLATE "und-x-icu"
>=20
> or whatever it is, is pretty useful.
>=20
> So, attached is a small patch to add this.

This collation has an empty pg_collation.collversion column, instead
of being set to the same value as "und-x-icu" to track its version.


postgres=3D# select * from pg_collation  where collname=3D'unicode' \gx
-[ RECORD 1 ]-------+--------
oid		    | 963
collname	    | unicode
collnamespace	    | 11
collowner	    | 10
collprovider	    | i
collisdeterministic | t
collencoding	    | -1
collcollate	    |=20
collctype	    |=20
colliculocale	    | und
collicurules	    |=20
collversion	    |=20

The original patch implements this as an INSERT in which it would be easy to
fix I guess, but in current HEAD it comes as an entry in
include/catalog/pg_collation.dat:

{ oid =3D> '963',
  descr =3D> 'sorts using the Unicode Collation Algorithm with default
settings',
  collname =3D> 'unicode', collprovider =3D> 'i', collencoding =3D> '-1',
  colliculocale =3D> 'und' },

Should it be converted back into an INSERT or better left
in this file and collversion being updated afterwards?


Best regards,
--=20
Daniel V=E9rit=E9
https://postgresql.verite.pro/
Twitter: @DanielVerite