To: Thom Brown <thom@linux.com>
cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Command Triggers, patch v11 
In-reply-to: 
 <CAA-aLv5zuJC2RtOPu_=-XOhJFROWLA7P=dtVHgHSdRp5wEzkjQ@mail.gmail.com>
References: <m24nufq466.fsf@2ndQuadrant.fr>
	<CAA-aLv5H5_ALMRZFatX-wDEz1meMvQVJOsBBFTYox65jzAoN5Q@mail.gmail.com>
	<CAA-aLv4w9B27QP17zU-osme58gks0yEH7j8p5p1tKCWp2oq_Hw@mail.gmail.com>
	<CAA-aLv6Was-jZmigbH3_eLH3eqsEUPpf-p7FT2s1FjBdXAbeNA@mail.gmail.com>
	<CAA-aLv7=+b+CiaDrWi7bKBtnW=jMarVC1HpB0a+erTKP3B=5Zw@mail.gmail.com>
	<CAA-aLv4jkA-s9y+bW_53zfz0Zt2azULQ2dppQYoRRpWmW2fvNw@mail.gmail.com>
	<m28vjo2hlm.fsf@2ndQuadrant.fr>
	<CAA-aLv5zuJC2RtOPu_=-XOhJFROWLA7P=dtVHgHSdRp5wEzkjQ@mail.gmail.com>
Comments: In-reply-to Thom Brown <thom@linux.com>
	message dated "Tue, 28 Feb 2012 11:43:54 +0000"
Date: Tue, 28 Feb 2012 10:03:57 -0500
Message-ID: <4965.1330441437@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Thom Brown <thom@linux.com> writes:
> Well the problem is that you can add commands to a trigger en masse,
> but you can only remove them one at a time.  Couldn't we at least
> allow the removal of multiple commands at the same time?  The docs you
> wrote suggest you can do this, but you can't.

This seems over-complicated.  Triggers on tables do not have alterable
properties, why should command triggers?  I vote for

	CREATE COMMAND TRIGGER name ... properties ...;

	DROP COMMAND TRIGGER name;

full stop.  If you want to run the same trigger function on some more
commands, add another trigger name.

			regards, tom lane