Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 8A71563261C for ; Fri, 9 Jan 2009 10:12:27 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 63547-05 for ; Fri, 9 Jan 2009 10:12:21 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ew0-f21.google.com (mail-ew0-f21.google.com [209.85.219.21]) by mail.postgresql.org (Postfix) with ESMTP id 745A963262F for ; Fri, 9 Jan 2009 10:12:19 -0400 (AST) Received: by ewy14 with SMTP id 14so11404695ewy.19 for ; Fri, 09 Jan 2009 06:12:18 -0800 (PST) Received: by 10.210.88.7 with SMTP id l7mr7550462ebb.3.1231510338160; Fri, 09 Jan 2009 06:12:18 -0800 (PST) Received: from ?88.195.102.92? ([88.195.102.92]) by mx.google.com with ESMTPS id c9sm60662065nfi.45.2009.01.09.06.12.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Jan 2009 06:12:17 -0800 (PST) Message-ID: <49675B3F.20002@enterprisedb.com> Date: Fri, 09 Jan 2009 16:12:15 +0200 Organization: EnterpriseDB User-Agent: Mozilla-Thunderbird 2.0.0.17 (X11/20081018) MIME-Version: 1.0 To: PostgreSQL-development Subject: foreign_data test fails with non-C locale Content-Type: multipart/mixed; boundary="------------050708060603060204010700" From: Heikki Linnakangas X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/684 X-Sequence-Number: 131328 This is a multi-part message in MIME format. --------------050708060603060204010700 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit The foreign_data test case is failing when I run "make installcheck" against a server that's been initialized with a locale other than C (en_GB.UTF-8). The reason is the different ordering of upper and lower case characters, per attached diff file. We can simply add an alternative expected output file, but I'd prefer not to if we can modify the test case instead. We could rename some of the object so that they sort the same in all locales, but that seems a bit awkward in this case. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com --------------050708060603060204010700 Content-Type: text/plain; name="regression.diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="regression.diffs" *** /home/hlinnaka/git-sandbox/pgsql/src/test/regress/expected/foreign_data.out Fri Jan 9 13:11:06 2009 --- /home/hlinnaka/git-sandbox/pgsql/src/test/regress/results/foreign_data.out Fri Jan 9 15:47:27 2009 *************** *** 658,667 **** SELECT * FROM information_schema.foreign_servers ORDER BY 1, 2; foreign_server_catalog | foreign_server_name | foreign_data_wrapper_catalog | foreign_data_wrapper_name | foreign_server_type | foreign_server_version | authorization_identifier ------------------------+---------------------+------------------------------+---------------------------+---------------------+------------------------+-------------------------- - regression | S6 | regression | foo | | | foreign_data_user regression | s4 | regression | foo | oracle | | foreign_data_user regression | s5 | regression | foo | | 15.0 | regress_test_role regression | s6 | regression | foo | | 16.0 | regress_test_indirect regression | s8 | regression | postgresql | | | foreign_data_user regression | st1 | regression | foo | | | regress_test_indirect regression | st2 | regression | foo | | | regress_test_role --- 658,667 ---- SELECT * FROM information_schema.foreign_servers ORDER BY 1, 2; foreign_server_catalog | foreign_server_name | foreign_data_wrapper_catalog | foreign_data_wrapper_name | foreign_server_type | foreign_server_version | authorization_identifier ------------------------+---------------------+------------------------------+---------------------------+---------------------+------------------------+-------------------------- regression | s4 | regression | foo | oracle | | foreign_data_user regression | s5 | regression | foo | | 15.0 | regress_test_role regression | s6 | regression | foo | | 16.0 | regress_test_indirect + regression | S6 | regression | foo | | | foreign_data_user regression | s8 | regression | postgresql | | | foreign_data_user regression | st1 | regression | foo | | | regress_test_indirect regression | st2 | regression | foo | | | regress_test_role *************** *** 670,680 **** SELECT * FROM information_schema.foreign_server_options ORDER BY 1, 2, 3; foreign_server_catalog | foreign_server_name | option_name | option_value ------------------------+---------------------+------------------+-------------- - regression | S6 | mixed_case_names | true regression | s4 | dbname | b regression | s4 | host | a regression | s6 | dbname | b regression | s6 | host | a regression | s8 | connect_timeout | 30 regression | s8 | dbname | db1 (7 rows) --- 670,680 ---- SELECT * FROM information_schema.foreign_server_options ORDER BY 1, 2, 3; foreign_server_catalog | foreign_server_name | option_name | option_value ------------------------+---------------------+------------------+-------------- regression | s4 | dbname | b regression | s4 | host | a regression | s6 | dbname | b regression | s6 | host | a + regression | S6 | mixed_case_names | true regression | s8 | connect_timeout | 30 regression | s8 | dbname | db1 (7 rows) *************** *** 682,693 **** SELECT * FROM information_schema.user_mappings ORDER BY 1, 2, 3; authorization_identifier | foreign_server_catalog | foreign_server_name --------------------------+------------------------+--------------------- PUBLIC | regression | s4 PUBLIC | regression | s8 PUBLIC | regression | st1 - foreign_data_user | regression | S6 - foreign_data_user | regression | s4 - foreign_data_user | regression | s8 regress_test_role | regression | s5 regress_test_role | regression | s6 regress_test_role | regression | st1 --- 682,693 ---- SELECT * FROM information_schema.user_mappings ORDER BY 1, 2, 3; authorization_identifier | foreign_server_catalog | foreign_server_name --------------------------+------------------------+--------------------- + foreign_data_user | regression | s4 + foreign_data_user | regression | S6 + foreign_data_user | regression | s8 PUBLIC | regression | s4 PUBLIC | regression | s8 PUBLIC | regression | st1 regress_test_role | regression | s5 regress_test_role | regression | s6 regress_test_role | regression | st1 *************** *** 696,705 **** SELECT * FROM information_schema.user_mapping_options ORDER BY 1, 2, 3, 4; authorization_identifier | foreign_server_catalog | foreign_server_name | option_name | option_value --------------------------+------------------------+---------------------+-------------+----------------- - PUBLIC | regression | s4 | mapping | is public - PUBLIC | regression | st1 | modified | 1 foreign_data_user | regression | S6 | username | test_mixed_case foreign_data_user | regression | s8 | password | public regress_test_role | regression | s5 | modified | 1 regress_test_role | regression | s6 | username | test regress_test_role | regression | st1 | password | boo --- 696,705 ---- SELECT * FROM information_schema.user_mapping_options ORDER BY 1, 2, 3, 4; authorization_identifier | foreign_server_catalog | foreign_server_name | option_name | option_value --------------------------+------------------------+---------------------+-------------+----------------- foreign_data_user | regression | S6 | username | test_mixed_case foreign_data_user | regression | s8 | password | public + PUBLIC | regression | s4 | mapping | is public + PUBLIC | regression | st1 | modified | 1 regress_test_role | regression | s5 | modified | 1 regress_test_role | regression | s6 | username | test regress_test_role | regression | st1 | password | boo ====================================================================== --------------050708060603060204010700--