Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 69B6D63261D for ; Fri, 9 Jan 2009 10:17:50 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 64881-09 for ; Fri, 9 Jan 2009 10:17:47 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from alexis.jtlnet.com (alexis.jtlnet.com [69.36.9.81]) by mail.postgresql.org (Postfix) with ESMTP id 6F4AF632638 for ; Fri, 9 Jan 2009 10:17:47 -0400 (AST) Received: from [192.168.10.103] (cpe-065-190-223-140.nc.res.rr.com [::ffff:65.190.223.140]) (TLS: TLSv1/SSLv3,256bits,AES256-SHA) by alexis.jtlnet.com with esmtp; Fri, 09 Jan 2009 09:15:06 -0500 id 000802BC.49675BEB.00002460 Message-ID: <49675C87.8070303@dunslane.net> Date: Fri, 09 Jan 2009 09:17:43 -0500 From: Andrew Dunstan User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text SeaMonkey/1.0.9 MIME-Version: 1.0 To: Heikki Linnakangas CC: PostgreSQL-development Subject: Re: foreign_data test fails with non-C locale References: <49675B3F.20002@enterprisedb.com> In-Reply-To: <49675B3F.20002@enterprisedb.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/686 X-Sequence-Number: 131330 Heikki Linnakangas wrote: > The foreign_data test case is failing when I run "make installcheck" > against a server that's been initialized with a locale other than C > (en_GB.UTF-8). > > The reason is the different ordering of upper and lower case > characters, per attached diff file. We can simply add an alternative > expected output file, but I'd prefer not to if we can modify the test > case instead. We could rename some of the object so that they sort the > same in all locales, but that seems a bit awkward in this case. Regression tests have always failed on non-C locales AFAIK. The buildfarm goes out of its way to avoid that. cheers andrew