Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id C8D42632627 for ; Fri, 9 Jan 2009 10:25:39 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 66600-07 for ; Fri, 9 Jan 2009 10:25:33 -0400 (AST) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by mail.postgresql.org (Postfix) with SMTP id 1F7996323D8 for ; Fri, 9 Jan 2009 10:25:32 -0400 (AST) Received: (qmail invoked by alias); 09 Jan 2009 14:25:30 -0000 Received: from unknown (EHLO dhcp-eesp05-101-201.Finland.Sun.COM) [192.18.8.1] by mail.gmx.net (mp058) with SMTP; 09 Jan 2009 15:25:30 +0100 X-Authenticated: #495269 X-Provags-ID: V01U2FsdGVkX19V3Os1gfVViKXF1bnJqOEOjOmLauQNCc/6Pu5/mx DmHEk0F1fsd9UT Message-ID: <49675E4E.1080805@gmx.net> Date: Fri, 09 Jan 2009 16:25:18 +0200 From: Peter Eisentraut User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209) MIME-Version: 1.0 To: Andrew Dunstan CC: Heikki Linnakangas , PostgreSQL-development Subject: Re: foreign_data test fails with non-C locale References: <49675B3F.20002@enterprisedb.com> <49675C87.8070303@dunslane.net> In-Reply-To: <49675C87.8070303@dunslane.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.8 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/688 X-Sequence-Number: 131332 Andrew Dunstan wrote: > Regression tests have always failed on non-C locales AFAIK. The > buildfarm goes out of its way to avoid that. The regression tests should work just fine in non-C locales. If the buildfarm goes out of its way to avoid non-C locales, then it loses some significant code coverage, considering that there are several variant code paths for locales, and considering the amount of users that use them.