Received: from localhost (unknown [200.46.204.183])
	by mail.postgresql.org (Postfix) with ESMTP id 3A1FC63260E
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Fri,  9 Jan 2009 11:21:53 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 77886-07
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Fri,  9 Jan 2009 11:21:49 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from cdptpa-omtalb.mail.rr.com (cdptpa-omtalb.mail.rr.com
	[75.180.132.122])
	by mail.postgresql.org (Postfix) with ESMTP id B2F8563260C
	for <pgsql-hackers@postgresql.org>;
	Fri,  9 Jan 2009 11:21:49 -0400 (AST)
Received: from [192.168.10.103] (really [65.190.223.140])
	by cdptpa-omta06.mail.rr.com with ESMTP
	id <20090109152147.LEMF2036.cdptpa-omta06.mail.rr.com@[192.168.10.103]>;
	Fri, 9 Jan 2009 15:21:47 +0000
Message-ID: <49676B8A.8020707@dunslane.net>
Date: Fri, 09 Jan 2009 10:21:46 -0500
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Peter Eisentraut <peter_e@gmx.net>
CC: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: foreign_data test fails with non-C locale
References: <49675B3F.20002@enterprisedb.com> <49675C87.8070303@dunslane.net>
	<49675E4E.1080805@gmx.net>
In-Reply-To: <49675E4E.1080805@gmx.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none
X-Spam-Level: 
X-Archive-Number: 200901/698
X-Sequence-Number: 131342



Peter Eisentraut wrote:
> Andrew Dunstan wrote:
>> Regression tests have always failed on non-C locales AFAIK. The 
>> buildfarm goes out of its way to avoid that.
>
> The regression tests should work just fine in non-C locales.  If the 
> buildfarm goes out of its way to avoid non-C locales, then it loses 
> some significant code coverage, considering that there are several 
> variant code paths for locales, and considering the amount of users 
> that use them.

It was discussed here at the time, IIRC, and we put in the check 
precisely because other locales broke the buildfarm. Originally 
buildfarm just inherited the locale from its environment.

If it is no longer true that other locales break the tests, then I'm 
happy to examine alternatives.

cheers

andrew