Message-ID: <49678659.4040904@dunslane.net>
Date: Fri, 09 Jan 2009 12:16:09 -0500
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Guillaume Smet <guillaume.smet@gmail.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: foreign_data test fails with non-C locale
References: <49675B3F.20002@enterprisedb.com> <49675C87.8070303@dunslane.net>	
	<49675E4E.1080805@gmx.net> <49676B8A.8020707@dunslane.net>	
	<26314.1231518295@sss.pgh.pa.us>
	<1d4e0c10901090845h1d647297w68f6f9a70bb757ec@mail.gmail.com>
In-Reply-To: <1d4e0c10901090845h1d647297w68f6f9a70bb757ec@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Guillaume Smet wrote:
> On Fri, Jan 9, 2009 at 5:24 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>   
>> However, the
>> de facto policy is that we try to keep them passing in locales that
>> are used by any of the regular developers.  I think it would be useful
>> to have buildfarm members testing in a few common locales.
>>     
>
> If you define common locales, I can set up as many new animals as
> needed to cover the locales needed for any branch we'd like to test.
>
> Perhaps we should add a parameter to the buildfarm config file so that
> the buildfarm script can check the locale is accepted and set it
> directly. Considering that we won't have the locale information in the
> animal description, it's a good way to have it in the report.
>
>
>   

Sure, we can easily have buildfarm's initdb step set any locale (and 
encoding, for that matter) we like. That's a simple change.

cheers

andrew