From: Antonin Houska <ah@cybertec.at>
To: alvherre@kurilemu.de
cc: pgsql-hackers@lists.postgresql.org, Robert Treat <rob@xzilla.net>,
    Fujii Masao <masao.fujii@gmail.com>,
    Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: <202508201207.wiyqibatotwz@alvherre.pgsql>
References: <202508201207.wiyqibatotwz@alvherre.pgsql>
Comments: In-reply-to =?us-ascii?Q?=3D=3Futf-8=3FQ=3F=3DC3=3D81lvaro=3F=3D?=
 Herrera <alvherre@kurilemu.de>
   message dated "Wed, 20 Aug 2025 14:07:37 +0200."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Wed, 20 Aug 2025 16:22:41 +0200
Message-ID: <49679.1755699761@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/49679.1755699761%40localhost>
Precedence: bulk

=C3=81lvaro Herrera <alvherre@kurilemu.de> wrote:

> On 2025-Aug-20, Antonin Houska wrote:
>=20
> > There's an issue with the symlink, maybe some meson expert can help. In
> > particular, the CI on Windows ends up with the following error:
> >=20
> > ERROR: Tried to install symlink to missing file C:/cirrus/build/tmp_ins=
tall/usr/local/pgsql/bin/vacuumdb
>=20
> Hmm, that's not the problem I see in the CI run from the commitfest app:
>=20
> https://cirrus-ci.com/task/5608274336153600

I was referring to the other build that you shared off-list (probably
independent from cfbot):

https://cirrus-ci.com/build/4726227505774592

> [19:11:00.642] FAILED: [code=3D2] src/bin/scripts/vacuumdb.exe.p/vacuumdb=
.c.obj=20
> [19:11:00.642] "cl" "-Isrc\bin\scripts\vacuumdb.exe.p" "-Isrc\include" "-=
I..\src\include" "-Ic:\openssl\1.1\include" "-I..\src\include\port\win32" "=
-I..\src\include\port\win32_msvc" "-Isrc/interfaces/libpq" "-I..\src\interf=
aces\libpq" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/Od" "/Zi" "/Z=
c:preprocessor" "/DWIN32" "/DWINDOWS" "/D__WINDOWS__" "/D__WIN32__" "/D_CRT=
_SECURE_NO_DEPRECATE" "/D_CRT_NONSTDC_NO_DEPRECATE" "/wd4018" "/wd4244" "/w=
d4273" "/wd4101" "/wd4102" "/wd4090" "/wd4267" "/Fdsrc\bin\scripts\vacuumdb=
.exe.p\vacuumdb.c.pdb" /Fosrc/bin/scripts/vacuumdb.exe.p/vacuumdb.c.obj "/c=
" ../src/bin/scripts/vacuumdb.c
> [19:11:00.642] ../src/bin/scripts/vacuumdb.c(186): error C2059: syntax er=
ror: '}'
> [19:11:00.642] ../src/bin/scripts/vacuumdb.c(197): warning C4034: sizeof =
returns 0
>=20
> The real problem here seems to be the empty long_options_repack array.
> I removed it and started a new run to see what happens.  Running now:
> https://cirrus-ci.com/build/4961902171783168

The symlink issue occurred at "Windows - Server 2019, MinGW64 - Meson", whe=
re
the code compiled well. The compilation failure mentioned above comes from
"Windows - Server 2019, VS 2019 - Meson & ninja". I think it's still possib=
le
that the symlink issue will occur there once the compilation is fixed.

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com