Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pMXHm-0004UK-7g
	for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Jan 2023 16:45:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pMXHl-0001il-2m
	for pgsql-hackers@arkaria.postgresql.org; Mon, 30 Jan 2023 16:45:37 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pMXHk-0001ic-Pa
	for pgsql-hackers@lists.postgresql.org; Mon, 30 Jan 2023 16:45:36 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pMXHe-0003cX-FH
	for pgsql-hackers@lists.postgresql.org; Mon, 30 Jan 2023 16:45:35 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30UGjRcu497113;
	Mon, 30 Jan 2023 11:45:27 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Richard Guo <guofenglinux@gmail.com>
cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
        "Finnerty,
    Jim" <jfinnert@amazon.com>
Subject: Re: Making Vars outer-join aware
In-reply-to: 
 <CAMbWs4-H7jBUpPfjDzswkRdU+43nxtmezyfAJoC9=WDyD6GwkQ@mail.gmail.com>
References: <830269.1656693747@sss.pgh.pa.us>
 <CAMbWs49KZO2VvMqo+1MQfaX4cun7vhF=5RgVdpA0gjJcj77HFQ@mail.gmail.com>
 <1903934.1657031040@sss.pgh.pa.us> <553080.1657481916@sss.pgh.pa.us>
 <CAMbWs4-0cdVpgY0c2uULBCX2vPjQt3Fx3=XFZh-Mn=UWmxhG-A@mail.gmail.com>
 <1515100.1657633061@sss.pgh.pa.us>
 <CAMbWs4_va6UWcaiPSZpeRPFzpA=UKU+4zKkxqdfrcKoKA5nKWA@mail.gmail.com>
 <2217146.1657721363@sss.pgh.pa.us> <2055912.1659383493@sss.pgh.pa.us>
 <CAMbWs480igxj6hTbvD0WEnzT4XJ8hJXg71EVJO_BcQqN90MQuA@mail.gmail.com>
 <1188905.1660666103@sss.pgh.pa.us> <1405792.1660677844@sss.pgh.pa.us>
 <1538543.1660683428@sss.pgh.pa.us>
 <CAMbWs498oYx4pjzOsjxu0wG0D73e2+OFAqkbPotcSJDKzm-s4Q@mail.gmail.com>
 <2741731.1660848346@sss.pgh.pa.us>
 <CAMbWs4-mvPPCJ1W6iK6dD5HiNwoJdi6mZp=-7mE8N9Sh+cd0tQ@mail.gmail.com>
 <CAMbWs4_WNcvQGiFMLJanj3h6WMzFi6P-=bifmnuXUcg4PSXQgA@mail.gmail.com>
 <1035990.1667261942@sss.pgh.pa.us> <2901865.1667685211@sss.pgh.pa.us>
 <CAMbWs4_pH7w7voY0AejUM4RiKq-Xuf+sXmoF8PcQwzNrsagEXA@mail.gmail.com> <CAMbWs!
 4_gXgGdkkOraUPEoZD_Q3xTW7FTxfomW+fxPN2Kr-YSXg@mail.gmail.com>
 <4019771.1672155080@sss.pgh.pa.us>
 <CAMbWs4_JDDdXvEBWtTao9ZTwOGdDCU7X-=bF7yi9G1u_-b0Dfw@mail.gmail.com>
 <323812.1672241806@sss.pgh.pa.us> <2043562.1674506286@sss.pgh.pa.us>
 <CAMbWs4-H7jBUpPfjDzswkRdU+43nxtmezyfAJoC9=WDyD6GwkQ@mail.gmail.com>
Comments: In-reply-to Richard Guo <guofenglinux@gmail.com>
	message dated "Mon, 30 Jan 2023 17:56:38 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <497111.1675097127.1@sss.pgh.pa.us>
Date: Mon, 30 Jan 2023 11:45:27 -0500
Message-ID: <497112.1675097127@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/497112.1675097127%40sss.pgh.pa.us>
Precedence: bulk

Richard Guo <guofenglinux@gmail.com> writes:
> Sorry for the delayed reply.  I don't have any more review comments at
> the moment, except a nitpicking one.

> In optimizer/README at line 729 there is a query as

>     SELECT * FROM a
>       LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = b.y)
>     WHERE a.x = 1;

> I think it should be

>     SELECT * FROM a
>       LEFT JOIN (SELECT * FROM b WHERE b.z = 1) ss ON (a.x = ss.y)
>     WHERE a.x = 1;

Oh, good catch, thanks.

> I have no objection to get it committed.

I'll push forward then.  Thanks for reviewing!

			regards, tom lane