From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <pchampion@vmware.com>
cc: "michael@paquier.xyz" <michael@paquier.xyz>,
        "daniel@yesql.se" <daniel@yesql.se>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Make jsonapi usable from libpq
In-reply-to: <c475057da66fdc5ae707a89f5b44dd8508b86f7e.camel@vmware.com>
References: <a250d475ba1c0cc0efb7dfec8e538fcc77cdcb8e.camel@vmware.com>
 <YNQedHwheUaTnnGt@paquier.xyz>
 <daeb22ec6ca8ef61e94d766a9b35fb03cabed38e.camel@vmware.com>
 <YNZ2mnsbDVJQrA/a@paquier.xyz>
 <c475057da66fdc5ae707a89f5b44dd8508b86f7e.camel@vmware.com>
Comments: In-reply-to Jacob Champion <pchampion@vmware.com>
	message dated "Tue, 29 Jun 2021 18:09:54 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <497373.1624992620.1@sss.pgh.pa.us>
Date: Tue, 29 Jun 2021 14:50:20 -0400
Message-ID: <497374.1624992620@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/497374.1624992620%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <pchampion@vmware.com> writes:
> What would you think about a src/port of asprintf()? Maybe libpq
> doesn't change quickly enough to worry about it, but having developers
> revisit stack allocation for strings every time they target the libpq
> parts of the code seems like a recipe for security problems.

The existing convention is to use pqexpbuffer.c, which seems strictly
cleaner and more robust than asprintf.  In particular its behavior under
OOM conditions is far easier/safer to work with.  Maybe we should consider
moving that into src/common/ so that it can be used by code that's not
tightly bound into libpq?

			regards, tom lane