Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: Set notice receiver before libpq connection startup
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHGQGwHBPqis=pP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw@mail.gmail.com>
Date: Thu, 28 May 2026 13:46:45 +0800
Cc: Peter Eisentraut <peter@eisentraut.org>,
 Rafia Sabih <rafia.pghackers@gmail.com>,
 vignesh C <vignesh21@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <4974E7EE-5E95-456E-B79F-B26F4D7339E5@gmail.com>
References: <A2B8B7DE-C119-492F-A9FA-14CF86849777@gmail.com>
 <CAHGQGwHnz7FoSx+qQsAHBx_j8Tks+SC-kAPTevrKYfrL08Ee9Q@mail.gmail.com>
 <978D8971-08C3-4AAD-AE8B-976D753C882A@gmail.com>
 <CALDaNm3UyoQ91gW2bRP4PXnnfAv3GfmCik614-AtQCiEUAjQYw@mail.gmail.com>
 <6B9A85F9-B632-4286-98AF-9EC435019055@gmail.com>
 <CA+FpmFdfyBhuiou1uqe94UR3WCg57wM5FsooUx2w27aABGoyag@mail.gmail.com>
 <CAHGQGwHU2E7h7XBCBNK7OJ+OAx7Xkwn+yUb7o5p5GxExi4fzAw@mail.gmail.com>
 <0DCA82A4-7C10-40A7-AEF5-827171160FE8@gmail.com>
 <CAHGQGwEvA2a+jXZdVrdybX9OmWguSU4Q8wEhZxWKkDMOZHnuMQ@mail.gmail.com>
 <0C00CA35-D0C5-40EB-9C23-9F871DCE74E9@gmail.com>
 <2620a664-7b44-48b2-9aa8-5f0131702d9c@eisentraut.org>
 <4FD8124D-6D42-4481-9C41-B658E5378364@gmail.com>
 <CAHGQGwHBPqis=pP7ui-x1vNboG5dGHkieVJoEbZfEkFgNnU1Zw@mail.gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/4974E7EE-5E95-456E-B79F-B26F4D7339E5%40gmail.com>
Precedence: bulk


> On May 28, 2026, at 13:22, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Thu, May 28, 2026 at 9:40=E2=80=AFAM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>> The committed patch violates the .gitattributes whitespace rules:
>>>=20
>>> git show --check 06a5c3cdef02
>>>=20
>>> contrib/postgres_fdw/connection.c:651: indent with spaces.
>>> +                                                   /* expand_dbname =
=3D */ false);
>>>=20
>>> It is unfortunate that pgindent produces this layout that =
contradicts the git configuration.  (The current formatting also doesn't =
look like what I would produce in an editor, so I think git is right =
here.)
>>>=20
>>> Maybe we could reformat this slightly to avoid that?  (unless =
someone wants to try to fix pgindent)
>=20
> Thanks for the report!
>=20
>=20
>> Ah, I was not aware of the whitespace rule. I think it was not =
pgindent; I made that change manually. I added =E2=80=9C=3D=E2=80=9D =
because I thought it might read more fluently.
>>=20
>> Attached is a fix for that.
>=20
> Thanks for the patch!
>=20
> I suspect the whitespace issue was caused by pgindent that I ran
> before committing the patch.
>=20
> -     /* expand_dbname =3D */ false);
> +    false /* expand_dbname */ );
>=20
> I think "/* expand_dbname =3D */ false" looks better. =
libpqwalreceiver.c
> also uses that comment style. So how about the attached v2 patch, =
which
> reformats the comment accordingly?
>=20
> After applying the v2 patch, I confirmed that neither "git show =
--check ..."
> nor pgindent reports any issues.
>=20
> Regards,
>=20
> --=20
> Fujii Masao
> <v2-0001-Fix-an-indentation-problem-in-postgres_fdw-connec.patch>

Oh, I misunderstood the problem. Nice to learn a new thing, I never knew =
git show check before. Yes, v2 passed =E2=80=9Cgit show --check =
d359d02a238=E2=80=9D.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/