Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kNqRg-0003vs-0d
	for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Oct 2020 04:43:56 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kNqRe-0007bd-UK
	for pgsql-hackers@arkaria.postgresql.org; Thu, 01 Oct 2020 04:43:54 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1kNqRe-0007bS-Nh
	for pgsql-hackers@lists.postgresql.org; Thu, 01 Oct 2020 04:43:54 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <masao.fujii@oss.nttdata.com>)
	id 1kNqRc-0001Vx-Kc
	for pgsql-hackers@postgresql.org; Thu, 01 Oct 2020 04:43:53 +0000
Received: from hnk.local (p1295030-ipngn4902funabasi.chiba.ocn.ne.jp
 [153.166.85.30])
	by oss.nttdata.com (Postfix) with ESMTPSA id 38AFC6237F;
	Thu,  1 Oct 2020 13:43:50 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com
Subject: Re: Implementing Incremental View Maintenance
To: Tatsuo Ishii <ishii@sraoss.co.jp>, michael@paquier.xyz
Cc: thomas.munro@gmail.com, nagata@sraoss.co.jp,
 pgsql-hackers@postgresql.org, takuma.hoshiai@gmail.com,
 amitlangote09@gmail.com, alvherre@2ndquadrant.com, kgrittn@gmail.com
References: 
 <CA+hUKG+3x4pmGNrwAn73EGwa5bJH0HbnkfjynJ=_nyvAUbx0Ag@mail.gmail.com>
 <20200917.094245.433560970731138050.t-ishii@sraoss.co.jp>
 <20201001033426.GB8130@paquier.xyz>
 <20201001.130351.116296702183559169.t-ishii@sraoss.co.jp>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
Message-ID: <497aa257-ecad-e439-39b3-944ab08d6fb9@oss.nttdata.com>
Date: Thu, 1 Oct 2020 13:43:49 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0)
 Gecko/20100101 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201001.130351.116296702183559169.t-ishii@sraoss.co.jp>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk



On 2020/10/01 13:03, Tatsuo Ishii wrote:
>> On Thu, Sep 17, 2020 at 09:42:45AM +0900, Tatsuo Ishii wrote:
>>> I am asking because these patch sets are now getting closer to
>>> committable state in my opinion, and if there's someting wrong, it
>>> should be fixed soon so that these patches are getting into the master
>>> branch.
>>>
>>> I think this feature has been long awaited by users and merging the
>>> patches should be a benefit for them.
>>
>> I don't have much thoughts to offer about that, but this patch is
>> failing to apply, so a rebase is at least necessary.
> 
> Yes. I think he is going to post a new patch (possibly with
> enhancements) soon.

When I glanced the doc patch (i.e., 0012), I found some typos.

+    <command>CRATE INCREMENTAL MATERIALIZED VIEW</command>, for example:

Typo: CRATE should be CREATE ?

+    with <literal>__ivm_</literal> and they contains information required

Typo: contains should be contain ?

+    For exmaple, here are two materialized views based on the same view

Typo: exmaple should be example ?

+    maintenance can be lager than <command>REFRESH MATERIALIZED VIEW</command>

Typo: lager should be larger ?

+postgres=# SELECt * FROM m; -- automatically updated

Typo: SELECt should be SELECT ?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION