Message-ID: <4984CBCF.1040703@dunslane.net>
Date: Sat, 31 Jan 2009 17:08:15 -0500
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Zdenek Kotala <Zdenek.Kotala@Sun.COM>
CC: Guillaume Smet <guillaume.smet@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>,
	Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: foreign_data test fails with non-C locale
References: <49675B3F.20002@enterprisedb.com> <49675C87.8070303@dunslane.net>
	<49675E4E.1080805@gmx.net> <49676B8A.8020707@dunslane.net>
	<26314.1231518295@sss.pgh.pa.us>
	<1d4e0c10901090845h1d647297w68f6f9a70bb757ec@mail.gmail.com>
	<49678659.4040904@dunslane.net> <1232396014.1406.7.camel@localhost>
	<497A9F9F.6030600@dunslane.net> <1232795937.1385.7.camel@localhost>
In-Reply-To: <1232795937.1385.7.camel@localhost>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


Zdenek Kotala wrote:
>> PL-check gives the diff below on PLTCL tests under en_US locale. I guess 
>> the simplest answer is to add an alternative result file.
>>     
>
> Yes, I thought about add locale suffix for alternative result file, but
> it could be useless overhead.
>
> But some tests can be modified. For example 
>
>  select * from T_pkey1 order by key1 using @<, key2;
>
> can be rewritten as
>
>   select * from T_pkey1 order by key1 using @<, key2::name;
>
>
>
>   

Is that the preferred solution? I want to fix this so I can re-enable 
building with TCL in dungbeetle.

cheers

andrew