Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x5yMj-000OLu-1X
	for pgsql-hackers@arkaria.postgresql.org;
	Mon, 14 Sep 2026 04:32:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1x5yMi-00BIY5-2o
	for pgsql-hackers@arkaria.postgresql.org;
	Mon, 14 Sep 2026 04:32:24 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1x5yMi-00BIXx-1f
	for pgsql-hackers@lists.postgresql.org;
	Mon, 14 Sep 2026 04:32:24 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1x5yMf-00000000HL3-2SRQ
	for pgsql-hackers@lists.postgresql.org;
	Mon, 14 Sep 2026 04:32:23 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 68E4WIZe049856;
	Mon, 14 Sep 2026 00:32:18 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
cc: pgsql-hackers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: Translation of the NextOID message in pg_controldata
In-reply-to: <20260914.124645.2220219320843846932.horikyota.ntt@gmail.com>
References: <20260914.124645.2220219320843846932.horikyota.ntt@gmail.com>
Comments: In-reply-to Kyotaro Horiguchi <horikyota.ntt@gmail.com>
	message dated "Mon, 14 Sep 2026 12:46:45 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <49854.1789360338.1@sss.pgh.pa.us>
Date: Mon, 14 Sep 2026 00:32:18 -0400
Message-ID: <49855.1789360338@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/49855.1789360338%40sss.pgh.pa.us>
Precedence: bulk

Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> Commit cb298616463 changed the following line:

> -	printf(_("Latest checkpoint's NextOID:          %u\n"),
> +	printf(_("Latest checkpoint's NextOID:          " OID8_FORMAT "\n"),

> It appears that xgettext does not recognize PostgreSQL's OID8_FORMAT
> macro and therefore extracts only the preceding string literal as the
> msgid. In contrast, PRIu64, which is used in the same file, is
> correctly extracted as %<PRIu64>. Therefore, shouldn't we use "%"
> PRIu64 instead of OID8_FORMAT here as well?

That would be fairly sad, because it means hard-wiring the fact that
Oid8 is the same as uint64 in a bunch of non-obvious places.
Admittedly, we've lived with formatting Oid as %u for a long time.
But can we fix this some other way?

			regards, tom lane