Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvgs3-0002yO-1e for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Aug 2018 10:41:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fvgs1-00015L-75 for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Aug 2018 10:41:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fvgs0-00015E-Tn for pgsql-hackers@lists.postgresql.org; Fri, 31 Aug 2018 10:41:41 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fvgrx-0003m6-KY for pgsql-hackers@postgresql.org; Fri, 31 Aug 2018 10:41:39 +0000 Received: by mail-lj1-x231.google.com with SMTP id q127-v6so9694123ljq.11 for ; Fri, 31 Aug 2018 03:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=U6aD8Guvn0+ZIRfhyCuPPhHWsIMX+SOYW0neJZiDYNM=; b=GOKabGqLxInvJIGYvD5fDMogFrmwYmuctoAiwXAKjPNDJYJ4uxia1InZpq3Td6rRck hMtrRJc2YXFNxHRAIHzzgMoPhWrPmpOOsFMa3Pr6J2d5kOLVU2sBF0Ash0ndic1YdA2a tYqT2DIv7FFV9Kbbr+J7YHGkPgs1RaUhJyMO2+6E+BKls5GwloC55OHP2nv3nOVCV3PA 0x0sIKSLRJBTeroApsMUdbpsEHIG1MyVR0sKGl3CS9ng1IgkGcBZ2CRUDKVvKnI4NQyZ Gmv7127c8ThLN9c7h4dL0QYuEbFYAOyn4HNwJrPlRqrr2jynMoH09UAtKJlyttOiYxBH 32IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=U6aD8Guvn0+ZIRfhyCuPPhHWsIMX+SOYW0neJZiDYNM=; b=paZdyRyPUFuVl8kXeGNSWuPL2fL6iAHhQak+44oHFtqiFO7WQV0563tVcVRwI7nfO4 /+Pcfjy4o/gIcw52mjOpelHXixqEJBenXchSNZWMeg4tZVrXL2iTnYAJBADUGSTQth4d R5Sae7BA+dIS3gWcX+YwK3ftsNUZBs/yU7u/noyemLNLUTtsoo6b6Y9+f5mwb7yLR3V1 oBJJ1U333x2ayhMg7gvxfsjK6xiXJqDlrb7oR7YdUIfceHw/CbSOkeukbdZWq30Ues4d Fs9lyl907x9FDco1xKqqvLT6dYSbZPgZ4yC+oOt8VZ+UZJYroHQkYmD2b1qwKykn3Up0 Bovw== X-Gm-Message-State: APzg51AxGXbReps8SptUIxAzUiVz5xqfmqV/5LFvCDV+hWilleUSRv8J 8OlSM0/Bd3YIBSBHp8tm16IRDulL1pw= X-Google-Smtp-Source: ANB0VdbqZUqxK3zSDhFwoQgfiuV7uFpvkSYrbfuk3W+W6fDc/hEcP5hLCXsbKAiwERmcYZKbsT3zkw== X-Received: by 2002:a2e:9d0c:: with SMTP id t12-v6mr9911323lji.75.1535712096541; Fri, 31 Aug 2018 03:41:36 -0700 (PDT) Received: from [192.168.27.213] ([93.174.131.141]) by smtp.gmail.com with ESMTPSA id m11-v6sm671847lfk.70.2018.08.31.03.41.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 31 Aug 2018 03:41:35 -0700 (PDT) Subject: Re: Hint to set owner for tablespace directory To: Rafia Sabih Cc: Michael Paquier , PostgreSQL-development References: <5ca60e1a-26f9-89fd-e912-021dd2b8afe2@gmail.com> <20180824021853.GG30782@paquier.xyz> <3deda6f3-3dfb-0246-905b-f76638b7658f@gmail.com> From: Maksim Milyutin Message-ID: <498a6ff8-7036-bec9-7d09-f3e24cb65b96@gmail.com> Date: Fri, 31 Aug 2018 13:41:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------46060733F3E6826390D6008B" Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This is a multi-part message in MIME format. --------------46060733F3E6826390D6008B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 08/31/2018 01:12 PM, Rafia Sabih wrote: > > > On Fri, Aug 31, 2018 at 3:30 PM, Maksim Milyutin > wrote: > > On 08/31/2018 11:55 AM, Rafia Sabih wrote: > >> >> Adding to that this patch needs a rebase. And, please don't >> forget to run 'git diff --check', as it has some white-space issues. > >  git apply /home/edb/Desktop/patches/others/owner_tbsp_hint.patch >  /home/edb/Desktop/patches/others/owner_tbsp_hint.patch:9: trailing > whitespace. >         { > /home/edb/Desktop/patches/others/owner_tbsp_hint.patch:10: trailing > whitespace. >             bool wrong_owner = (errno == EPERM); This is hex+ASCII display (from *hexdump -C owner_tbsp_hint.patch* output) of code fragment above: 000001a0  0a 20 09 09 65 6c 73 65  0a 2b 09 09 7b 0a 2b 09  |. ..else.+..{.+.| 000001b0  09 09 62 6f 6f 6c 20 77  72 6f 6e 67 5f 6f 77 6e |..bool wrong_own| 000001c0  65 72 20 3d 20 28 65 72  72 6e 6f 20 3d 3d 20 45 |er = (errno == E| 000001d0  50 45 52 4d 29 3b 0a 2b  0a 20 09 09 09 65 72 65 |PERM);.+. ...ere| Problem lines don't have trailing whitespaces, only line feed (0x0a) symbols > This is what I got. Please correct me if I am missng anything. I am > using centos 7,  just an FYI. My git version is 2.7.4. -- Regards, Maksim Milyutin --------------46060733F3E6826390D6008B Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

On 08/31/2018 01:12 PM, Rafia Sabih wrote:



On Fri, Aug 31, 2018 at 3:30 PM, Maksim Milyutin <milyutinma@gmail.com> wrote:

On 08/31/2018 11:55 AM, Rafia Sabih wrote:


Adding to that this patch needs a rebase. And, please don't forget to run 'git diff --check', as it has some white-space issues.

 git apply /home/edb/Desktop/patches/others/owner_tbsp_hint.patch
 /home/edb/Desktop/patches/others/owner_tbsp_hint.patch:9: trailing whitespace.
        {
/home/edb/Desktop/patches/others/owner_tbsp_hint.patch:10: trailing whitespace.
            bool wrong_owner = (errno == EPERM);

This is hex+ASCII display (from *hexdump -C owner_tbsp_hint.patch* output) of code fragment above:

000001a0  0a 20 09 09 65 6c 73 65  0a 2b 09 09 7b 0a 2b 09  |. ..else.+..{.+.|
000001b0  09 09 62 6f 6f 6c 20 77  72 6f 6e 67 5f 6f 77 6e  |..bool wrong_own|
000001c0  65 72 20 3d 20 28 65 72  72 6e 6f 20 3d 3d 20 45  |er = (errno == E|
000001d0  50 45 52 4d 29 3b 0a 2b  0a 20 09 09 09 65 72 65  |PERM);.+. ...ere|

Problem lines don't have trailing whitespaces, only line feed (0x0a) symbols

This is what I got. Please correct me if I am missng anything. I am using centos 7,  just an FYI.

My git version is 2.7.4.

-- 
Regards, Maksim Milyutin
--------------46060733F3E6826390D6008B--