Subject: Re: [HACKERS] Regression tests vs existing users in an installation
To: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>
References: <20160716035456.GA181422@alvherre.pgsql>
 <25245.1468683514@sss.pgh.pa.us>
 <CA+TgmoZf-TodYQJz91bLm8WLsEefNhdJJfM1wn+AnYehadDwoA@mail.gmail.com>
 <23690.1468854782@sss.pgh.pa.us>
 <CA+Tgmobttcs_WcZivJ5dVmpS1MoKgDKF4d-dVRvWO4JhBDvFRA@mail.gmail.com>
 <1382.1561520002@sss.pgh.pa.us>
 <CA+TgmobN1d2BFL6Wa0YgrVLiVYhrB9TMWygHKDdAaEJtHprBHw@mail.gmail.com>
 <27282.1561668606@sss.pgh.pa.us> <20190628154110.GM2480@tamriel.snowman.net>
 <25897.1561828908@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <499f2909-d6e4-4f50-d88a-0e3dc9530f4e@2ndquadrant.com>
Date: Tue, 26 Nov 2019 22:10:15 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <25897.1561828908@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-06-29 19:21, Tom Lane wrote:
> Stephen Frost<sfrost@snowman.net>  writes:
>> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>>> We could make the new subdirectory be something specific like
>>> "src/test/modules/test_rolenames", but I think very likely we'll be
>>> wanting some additional test scripts that we likewise deem unsafe to
>>> run during "installcheck".  So I'd rather choose a more generic module
>>> name, but I'm not sure what ... "unsafe_tests"?
>> Agreed but haven't got any particularly good suggestions on names..
> Hearing no better suggestions, I went with "unsafe_tests" in the
> attached.

I found this directory, and it seems like a good place to add some more 
tests (other thread), but I'm puzzled why it's hidden under modules/, 
since it's not, well, a module.  Why is it not in src/test/?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services