Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cosvE-0000yE-4O for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2017 14:32:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cosvC-0004og-L9 for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2017 14:32:02 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cosvB-0004oH-Lj for pgsql-hackers@postgresql.org; Fri, 17 Mar 2017 14:32:01 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cosv8-0006Cc-JV for pgsql-hackers@postgresql.org; Fri, 17 Mar 2017 14:31:59 +0000 Received: from Davids-iMac.local (c-73-55-5-246.hsd1.fl.comcast.net [73.55.5.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id AA2AA5530B; Fri, 17 Mar 2017 14:31:57 +0000 (UTC) Subject: Re: PATCH: Make pg_stop_backup() archive wait optional To: "Tsunakawa, Takayuki" References: <758e3fd1-45b4-5e28-75cd-e9e7f93a4c02@pgmasters.net> <35b7530c-68ce-7090-e13c-e39e4dac9bca@pgmasters.net> <967b90bd-6b65-a18a-5266-bfa9191c40e6@pgmasters.net> <0f46c90e-2884-59be-69bf-8f467d4c9ba2@pgmasters.net> <081cbf08-35c1-4580-8c31-3ae70b507fb1@pgmasters.net> <0A3221C70F24FB45833433255569204D1F6B3F95@G01JPEXMBYT05> <0A3221C70F24FB45833433255569204D1F6B5134@G01JPEXMBYT05> Cc: Michael Paquier , Pg Hackers , Stephen Frost From: David Steele Message-ID: <49d70e8e-33bf-2390-e717-ba9562621aa4@pgmasters.net> Date: Fri, 17 Mar 2017 10:31:56 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <0A3221C70F24FB45833433255569204D1F6B5134@G01JPEXMBYT05> Content-Type: multipart/mixed; boundary="------------00A7F68E546BA134D9FB8187" X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is a multi-part message in MIME format. --------------00A7F68E546BA134D9FB8187 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 3/17/17 4:18 AM, Tsunakawa, Takayuki wrote: > From: pgsql-hackers-owner@postgresql.org >> [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Tsunakawa, >> Takayuki >> I made this ready for committer. The patch applied except for catversion.h, >> the patch content looks good, and the target test passed as follows: > > Sorry, I reverted this to waiting for author, because make check failed. src/test/regress/expected/opr_sanity.out seems to need revision because pg_stop_backup() was added. Well, that's embarrassing. When I recreated the function to add defaults I messed up the AS clause and did not pay attention to the results of the regression tests, apparently. Attached is a new version rebased on 88e66d1. Catalog version bump has also been omitted. Thanks, -- -David david@pgmasters.net --------------00A7F68E546BA134D9FB8187 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="pgstopbackup-wait-v4.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pgstopbackup-wait-v4.patch" ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9mdW5jLnNnbWwgYi9kb2Mvc3Jj L3NnbWwvZnVuYy5zZ21sCmluZGV4IDk0MDhhMjUuLjRkYzMwY2EgMTAwNjQ0 Ci0tLSBhL2RvYy9zcmMvc2dtbC9mdW5jLnNnbWwKKysrIGIvZG9jL3NyYy9z Z21sL2Z1bmMuc2dtbApAQCAtMTgzNTUsNyArMTgzNTUsNyBAQCBTRUxFQ1Qg c2V0X2NvbmZpZygnbG9nX3N0YXRlbWVudF9zdGF0cycsICdvZmYnLCBmYWxz ZSk7CiAgICAgICA8L3Jvdz4KICAgICAgIDxyb3c+CiAgICAgICAgPGVudHJ5 PgotICAgICAgICA8bGl0ZXJhbD48ZnVuY3Rpb24+cGdfc3RvcF9iYWNrdXAo PHBhcmFtZXRlcj5leGNsdXNpdmU8Lz4gPHR5cGU+Ym9vbGVhbjwvPik8L2Z1 bmN0aW9uPjwvbGl0ZXJhbD4KKyAgICAgICAgPGxpdGVyYWw+PGZ1bmN0aW9u PnBnX3N0b3BfYmFja3VwKDxwYXJhbWV0ZXI+ZXhjbHVzaXZlPC8+IDx0eXBl PmJvb2xlYW48Lz4gPG9wdGlvbmFsPiwgPHBhcmFtZXRlcj53YWl0X2Zvcl9h cmNoaXZlPC8+IDx0eXBlPmJvb2xlYW48Lz4gPC9vcHRpb25hbD4pPC9mdW5j dGlvbj48L2xpdGVyYWw+CiAgICAgICAgIDwvZW50cnk+CiAgICAgICAgPGVu dHJ5Pjx0eXBlPnNldG9mIHJlY29yZDwvdHlwZT48L2VudHJ5PgogICAgICAg IDxlbnRyeT5GaW5pc2ggcGVyZm9ybWluZyBleGNsdXNpdmUgb3Igbm9uLWV4 Y2x1c2l2ZSBvbi1saW5lIGJhY2t1cCAocmVzdHJpY3RlZCB0byBzdXBlcnVz ZXJzIGJ5IGRlZmF1bHQsIGJ1dCBvdGhlciB1c2VycyBjYW4gYmUgZ3JhbnRl ZCBFWEVDVVRFIHRvIHJ1biB0aGUgZnVuY3Rpb24pPC9lbnRyeT4KQEAgLTE4 NDM5LDcgKzE4NDM5LDEzIEBAIHBvc3RncmVzPSMgc2VsZWN0IHBnX3N0YXJ0 X2JhY2t1cCgnbGFiZWxfZ29lc19oZXJlJyk7CiAgICAgPGZ1bmN0aW9uPnBn X3N0YXJ0X2JhY2t1cDwvPi4gSW4gYSBub24tZXhjbHVzaXZlIGJhY2t1cCwg dGhlIGNvbnRlbnRzIG9mCiAgICAgdGhlIDxmaWxlbmFtZT5iYWNrdXBfbGFi ZWw8Lz4gYW5kIDxmaWxlbmFtZT50YWJsZXNwYWNlX21hcDwvPiBhcmUgcmV0 dXJuZWQKICAgICBpbiB0aGUgcmVzdWx0IG9mIHRoZSBmdW5jdGlvbiwgYW5k IHNob3VsZCBiZSB3cml0dGVuIHRvIGZpbGVzIGluIHRoZQotICAgIGJhY2t1 cCAoYW5kIG5vdCBpbiB0aGUgZGF0YSBkaXJlY3RvcnkpLgorICAgIGJhY2t1 cCAoYW5kIG5vdCBpbiB0aGUgZGF0YSBkaXJlY3RvcnkpLiAgVGhlcmUgaXMg YW4gb3B0aW9uYWwgc2Vjb25kCisgICAgcGFyYW1ldGVyIG9mIHR5cGUgYm9v bGVhbi4gIElmIGZhbHNlLCB0aGUgPGZ1bmN0aW9uPnBnX3N0b3BfYmFja3Vw PC8+CisgICAgd2lsbCByZXR1cm4gaW1tZWRpYXRlbHkgYWZ0ZXIgdGhlIGJh Y2t1cCBpcyBjb21wbGV0ZWQgd2l0aG91dCB3YWl0aW5nIGZvcgorICAgIFdB TCB0byBiZSBhcmNoaXZlZC4gIFRoaXMgYmVoYXZpb3IgaXMgb25seSB1c2Vm dWwgZm9yIGJhY2t1cAorICAgIHNvZnR3YXJlIHdoaWNoIGluZGVwZW5kZW50 bHkgbW9uaXRvcnMgV0FMIGFyY2hpdmluZy4gT3RoZXJ3aXNlLCBXQUwKKyAg ICByZXF1aXJlZCB0byBtYWtlIHRoZSBiYWNrdXAgY29uc2lzdGVudCBtaWdo dCBiZSBtaXNzaW5nIGFuZCBtYWtlIHRoZSBiYWNrdXAKKyAgICB1c2VsZXNz LgogICAgPC9wYXJhPgogCiAgICA8cGFyYT4KZGlmZiAtLWdpdCBhL3NyYy9i YWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2dmdW5jcy5jIGIvc3JjL2JhY2tl bmQvYWNjZXNzL3RyYW5zYW0veGxvZ2Z1bmNzLmMKaW5kZXggOTZhYTE1ZS4u MWVmOWYyYiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5z YW0veGxvZ2Z1bmNzLmMKKysrIGIvc3JjL2JhY2tlbmQvYWNjZXNzL3RyYW5z YW0veGxvZ2Z1bmNzLmMKQEAgLTE5MCw2ICsxOTAsNyBAQCBwZ19zdG9wX2Jh Y2t1cF92MihQR19GVU5DVElPTl9BUkdTKQogCWJvb2wJCW51bGxzWzNdOwog CiAJYm9vbAkJZXhjbHVzaXZlID0gUEdfR0VUQVJHX0JPT0woMCk7CisJYm9v bAkJd2FpdF9mb3JfYXJjaGl2ZSA9IFBHX0dFVEFSR19CT09MKDEpOwogCVhM b2dSZWNQdHIJc3RvcHBvaW50OwogCiAJLyogY2hlY2sgdG8gc2VlIGlmIGNh bGxlciBzdXBwb3J0cyB1cyByZXR1cm5pbmcgYSB0dXBsZXN0b3JlICovCkBA IC0yMzIsNyArMjMzLDcgQEAgcGdfc3RvcF9iYWNrdXBfdjIoUEdfRlVOQ1RJ T05fQVJHUykKIAkJICogU3RvcCB0aGUgZXhjbHVzaXZlIGJhY2t1cCwgYW5k IHNpbmNlIHdlJ3JlIGluIGFuIGV4Y2x1c2l2ZSBiYWNrdXAKIAkJICogcmV0 dXJuIE5VTEwgZm9yIGJvdGggYmFja3VwX2xhYmVsIGFuZCB0YWJsZXNwYWNl X21hcC4KIAkJICovCi0JCXN0b3Bwb2ludCA9IGRvX3BnX3N0b3BfYmFja3Vw KE5VTEwsIHRydWUsIE5VTEwpOworCQlzdG9wcG9pbnQgPSBkb19wZ19zdG9w X2JhY2t1cChOVUxMLCB3YWl0X2Zvcl9hcmNoaXZlLCBOVUxMKTsKIAkJZXhj bHVzaXZlX2JhY2t1cF9ydW5uaW5nID0gZmFsc2U7CiAKIAkJbnVsbHNbMV0g PSB0cnVlOwpAQCAtMjUwLDcgKzI1MSw3IEBAIHBnX3N0b3BfYmFja3VwX3Yy KFBHX0ZVTkNUSU9OX0FSR1MpCiAJCSAqIFN0b3AgdGhlIG5vbi1leGNsdXNp dmUgYmFja3VwLiBSZXR1cm4gYSBjb3B5IG9mIHRoZSBiYWNrdXAgbGFiZWwK IAkJICogYW5kIHRhYmxlc3BhY2UgbWFwIHNvIHRoZXkgY2FuIGJlIHdyaXR0 ZW4gdG8gZGlzayBieSB0aGUgY2FsbGVyLgogCQkgKi8KLQkJc3RvcHBvaW50 ID0gZG9fcGdfc3RvcF9iYWNrdXAobGFiZWxfZmlsZS0+ZGF0YSwgdHJ1ZSwg TlVMTCk7CisJCXN0b3Bwb2ludCA9IGRvX3BnX3N0b3BfYmFja3VwKGxhYmVs X2ZpbGUtPmRhdGEsIHdhaXRfZm9yX2FyY2hpdmUsIE5VTEwpOwogCQlub25l eGNsdXNpdmVfYmFja3VwX3J1bm5pbmcgPSBmYWxzZTsKIAkJY2FuY2VsX2Jl Zm9yZV9zaG1lbV9leGl0KG5vbmV4Y2x1c2l2ZV9iYXNlX2JhY2t1cF9jbGVh bnVwLCAoRGF0dW0pIDApOwogCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9j YXRhbG9nL3N5c3RlbV92aWV3cy5zcWwgYi9zcmMvYmFja2VuZC9jYXRhbG9n L3N5c3RlbV92aWV3cy5zcWwKaW5kZXggYjY1NTJkYS4uYzJiMGJlZCAxMDA2 NDQKLS0tIGEvc3JjL2JhY2tlbmQvY2F0YWxvZy9zeXN0ZW1fdmlld3Muc3Fs CisrKyBiL3NyYy9iYWNrZW5kL2NhdGFsb2cvc3lzdGVtX3ZpZXdzLnNxbApA QCAtOTg4LDYgKzk4OCwxMiBAQCBDUkVBVEUgT1IgUkVQTEFDRSBGVU5DVElP TgogICBSRVRVUk5TIHBnX2xzbiBTVFJJQ1QgVk9MQVRJTEUgTEFOR1VBR0Ug aW50ZXJuYWwgQVMgJ3BnX3N0YXJ0X2JhY2t1cCcKICAgUEFSQUxMRUwgUkVT VFJJQ1RFRDsKIAorQ1JFQVRFIE9SIFJFUExBQ0UgRlVOQ1RJT04gcGdfc3Rv cF9iYWNrdXAgKAorICAgICAgICBleGNsdXNpdmUgYm9vbGVhbiwgd2FpdF9m b3JfYXJjaGl2ZSBib29sZWFuIERFRkFVTFQgdHJ1ZSwKKyAgICAgICAgT1VU IGxzbiBwZ19sc24sIE9VVCBsYWJlbGZpbGUgdGV4dCwgT1VUIHNwY21hcGZp bGUgdGV4dCkKKyAgUkVUVVJOUyBTRVRPRiByZWNvcmQgU1RSSUNUIFZPTEFU SUxFIExBTkdVQUdFIGludGVybmFsIGFzICdwZ19zdG9wX2JhY2t1cF92MicK KyAgUEFSQUxMRUwgUkVTVFJJQ1RFRDsKKwogLS0gbGVnYWN5IGRlZmluaXRp b24gZm9yIGNvbXBhdGliaWxpdHkgd2l0aCA5LjMKIENSRUFURSBPUiBSRVBM QUNFIEZVTkNUSU9OCiAgIGpzb25fcG9wdWxhdGVfcmVjb3JkKGJhc2UgYW55 ZWxlbWVudCwgZnJvbV9qc29uIGpzb24sIHVzZV9qc29uX2FzX3RleHQgYm9v bGVhbiBERUZBVUxUIGZhbHNlKQpAQCAtMTA4OCw3ICsxMDk0LDcgQEAgQVMg J2pzb25iX2luc2VydCc7CiAtLSBhdmFpbGFibGUgdG8gc3VwZXJ1c2VyIC8g Y2x1c3RlciBvd25lciwgaWYgdGhleSBjaG9vc2UuCiBSRVZPS0UgRVhFQ1VU RSBPTiBGVU5DVElPTiBwZ19zdGFydF9iYWNrdXAodGV4dCwgYm9vbGVhbiwg Ym9vbGVhbikgRlJPTSBwdWJsaWM7CiBSRVZPS0UgRVhFQ1VURSBPTiBGVU5D VElPTiBwZ19zdG9wX2JhY2t1cCgpIEZST00gcHVibGljOwotUkVWT0tFIEVY RUNVVEUgT04gRlVOQ1RJT04gcGdfc3RvcF9iYWNrdXAoYm9vbGVhbikgRlJP TSBwdWJsaWM7CitSRVZPS0UgRVhFQ1VURSBPTiBGVU5DVElPTiBwZ19zdG9w X2JhY2t1cChib29sZWFuLCBib29sZWFuKSBGUk9NIHB1YmxpYzsKIFJFVk9L RSBFWEVDVVRFIE9OIEZVTkNUSU9OIHBnX2NyZWF0ZV9yZXN0b3JlX3BvaW50 KHRleHQpIEZST00gcHVibGljOwogUkVWT0tFIEVYRUNVVEUgT04gRlVOQ1RJ T04gcGdfc3dpdGNoX3dhbCgpIEZST00gcHVibGljOwogUkVWT0tFIEVYRUNV VEUgT04gRlVOQ1RJT04gcGdfd2FsX3JlcGxheV9wYXVzZSgpIEZST00gcHVi bGljOwpkaWZmIC0tZ2l0IGEvc3JjL2luY2x1ZGUvY2F0YWxvZy9wZ19wcm9j LmggYi9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2MuaAppbmRleCA4MzZk NmZmLi4yMjYzNTY1IDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9jYXRhbG9n L3BnX3Byb2MuaAorKysgYi9zcmMvaW5jbHVkZS9jYXRhbG9nL3BnX3Byb2Mu aApAQCAtMzE3Miw3ICszMTcyLDcgQEAgREFUQShpbnNlcnQgT0lEID0gMjE3 MiAoIHBnX3N0YXJ0X2JhY2t1cAkJUEdOU1AgUEdVSUQgMTIgMSAwIDAgMCBm IGYgZiBmIHQgZiB2IHIKIERFU0NSKCJwcmVwYXJlIGZvciB0YWtpbmcgYW4g b25saW5lIGJhY2t1cCIpOwogREFUQShpbnNlcnQgT0lEID0gMjE3MyAoIHBn X3N0b3BfYmFja3VwCQkJUEdOU1AgUEdVSUQgMTIgMSAwIDAgMCBmIGYgZiBm IHQgZiB2IHIgMCAwIDMyMjAgIiIgX251bGxfIF9udWxsXyBfbnVsbF8gX251 bGxfIF9udWxsXyBwZ19zdG9wX2JhY2t1cCBfbnVsbF8gX251bGxfIF9udWxs XyApKTsKIERFU0NSKCJmaW5pc2ggdGFraW5nIGFuIG9ubGluZSBiYWNrdXAi KTsKLURBVEEoaW5zZXJ0IE9JRCA9IDI3MzkgKCBwZ19zdG9wX2JhY2t1cAkJ CVBHTlNQIFBHVUlEIDEyIDEgMSAwIDAgZiBmIGYgZiB0IHQgdiByIDEgMCAy MjQ5ICIxNiIgInsxNiwzMjIwLDI1LDI1fSIgIntpLG8sbyxvfSIgIntleGNs dXNpdmUsbHNuLGxhYmVsZmlsZSxzcGNtYXBmaWxlfSIgX251bGxfIF9udWxs XyBwZ19zdG9wX2JhY2t1cF92MiBfbnVsbF8gX251bGxfIF9udWxsXyApKTsK K0RBVEEoaW5zZXJ0IE9JRCA9IDI3MzkgKCBwZ19zdG9wX2JhY2t1cAkJCVBH TlNQIFBHVUlEIDEyIDEgMSAwIDAgZiBmIGYgZiB0IHQgdiByIDIgMCAyMjQ5 ICIxNiAxNiIgInsxNiwxNiwzMjIwLDI1LDI1fSIgIntpLGksbyxvLG99IiAi e2V4Y2x1c2l2ZSx3YWl0X2Zvcl9hcmNoaXZlLGxzbixsYWJlbGZpbGUsc3Bj bWFwZmlsZX0iIF9udWxsXyBfbnVsbF8gcGdfc3RvcF9iYWNrdXBfdjIgX251 bGxfIF9udWxsXyBfbnVsbF8gKSk7CiBERVNDUigiZmluaXNoIHRha2luZyBh biBvbmxpbmUgYmFja3VwIik7CiBEQVRBKGluc2VydCBPSUQgPSAzODEzICgg cGdfaXNfaW5fYmFja3VwCQlQR05TUCBQR1VJRCAxMiAxIDAgMCAwIGYgZiBm IGYgdCBmIHYgcyAwIDAgMTYgIiIgX251bGxfIF9udWxsXyBfbnVsbF8gX251 bGxfIF9udWxsXyBwZ19pc19pbl9iYWNrdXAgX251bGxfIF9udWxsXyBfbnVs bF8gKSk7CiBERVNDUigidHJ1ZSBpZiBzZXJ2ZXIgaXMgaW4gb25saW5lIGJh Y2t1cCIpOwo= --------------00A7F68E546BA134D9FB8187 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------00A7F68E546BA134D9FB8187--