Message-ID: <4A0B1329.5020206@enterprisedb.com>
Date: Wed, 13 May 2009 21:36:25 +0300
From: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Organization: EnterpriseDB
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Simon Riggs <simon@2ndQuadrant.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Fujii Masao <masao.fujii@gmail.com>,
	Guillaume Smet <guillaume.smet@gmail.com>,
	Peter Eisentraut <peter_e@gmx.net>,
	Kevin Grittner <Kevin.Grittner@wicourts.gov>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: New trigger option of pg_standby
References: <3f0b79eb0903242329j12865d55s348f5c873a956e71@mail.gmail.com>	
	<1239381103.16396.30.camel@ebony.2ndQuadrant>	
	<3f0b79eb0904122252t1f4c5860v919d199f399ccf72@mail.gmail.com>	
	<3f0b79eb0904132241p18084914g792cb8e5ab3eebb3@mail.gmail.com>	
	<3f0b79eb0904150101pb1c59a3ubb422867e8e6a944@mail.gmail.com>	
	<49EE1E3F.9050307@enterprisedb.com>	
	<3f0b79eb0904212209i7fbd8b68k71db1fef09c62751@mail.gmail.com>	
	<49F01D79.8020805@enterprisedb.com>	
	<3f0b79eb0904230515p751b5248n6ef96880617db055@mail.gmail.com>	
	<4A095A39.3030100@enterprisedb.com>	
	<3f0b79eb0905130127u3a3275b1w79f4d8cb729ded36@mail.gmail.com>	
	<4A0A86D2.9080602@enterprisedb.com> <1985.1242234105@sss.pgh.pa.us>
	<1242237523.3843.461.camel@ebony.2ndQuadrant>
In-Reply-To: <1242237523.3843.461.camel@ebony.2ndQuadrant>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Simon Riggs wrote:
> On Wed, 2009-05-13 at 13:01 -0400, Tom Lane wrote:
>> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>>> Does someone want to take a stab at writing a patch for that?
> 
> No, not if there is a likelihood the work would be wasted.

There always is.

(I would've wrote the patch myself right away, but I'm extremely busy at 
the moment. :-( Might take one more day before I get the time to finish 
it, and we don't have much time)

>> Does this conclusion mean that changing pg_standby is no longer
>> on the table for 8.4?  It certainly smells more like a new feature
>> than a bug fix.
> 
> I don't really understand this comment. Why would fixing a memory leak
> be worthwhile when fixing a potential for data loss be a deferrable
> activity?

Because the data loss is working as designed and documented, even though 
the design is not what most people want and the documentation could say 
that more prominently. That said, I'm in favor of changing this for 8.4.

> I will set-up pg_standby as an external module and we can change it from
> there. No more discussions-for-8.4 and I can update as required to
> support each release. So let's just remove it from contrib and be done.
> Counterthoughts?

That's a lot more drastic change to make in beta. Besides, the proposed 
fix required backend changes. I think we should keep it in contrib. (At 
least for this release: If we get more integrated replication options in 
8.5, that would be a good time to move pg_standby out of contrib if 
that's what we want.)

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com