Message-ID: <4A0B1A10.4070207@dunslane.net>
Date: Wed, 13 May 2009 15:05:52 -0400
From: Andrew Dunstan <andrew@dunslane.net>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.0.9-3.fc6 pango-text
	SeaMonkey/1.0.9
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Simon Riggs <simon@2ndQuadrant.com>, Fujii Masao <masao.fujii@gmail.com>,
	Guillaume Smet <guillaume.smet@gmail.com>,
	Peter Eisentraut <peter_e@gmx.net>,
	Kevin Grittner <Kevin.Grittner@wicourts.gov>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: New trigger option of pg_standby
References: <3f0b79eb0903242329j12865d55s348f5c873a956e71@mail.gmail.com>
	<1239381103.16396.30.camel@ebony.2ndQuadrant>
	<3f0b79eb0904122252t1f4c5860v919d199f399ccf72@mail.gmail.com>
	<3f0b79eb0904132241p18084914g792cb8e5ab3eebb3@mail.gmail.com>
	<3f0b79eb0904150101pb1c59a3ubb422867e8e6a944@mail.gmail.com>
	<49EE1E3F.9050307@enterprisedb.com>
	<3f0b79eb0904212209i7fbd8b68k71db1fef09c62751@mail.gmail.com>
	<49F01D79.8020805@enterprisedb.com>
	<3f0b79eb0904230515p751b5248n6ef96880617db055@mail.gmail.com>
	<4A095A39.3030100@enterprisedb.com>
	<3f0b79eb0905130127u3a3275b1w79f4d8cb729ded36@mail.gmail.com>
	<4A0A86D2.9080602@enterprisedb.com> <1985.1242234105@sss.pgh.pa.us>
	<1242237523.3843.461.camel@ebony.2ndQuadrant>
	<4A0B1329.5020206@enterprisedb.com>
	<14644.1242241073@sss.pgh.pa.us>
In-Reply-To: <14644.1242241073@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Tom Lane wrote:
> Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>   
>> That's a lot more drastic change to make in beta. Besides, the proposed 
>> fix required backend changes. I think we should keep it in contrib. (At 
>> least for this release: If we get more integrated replication options in 
>> 8.5, that would be a good time to move pg_standby out of contrib if 
>> that's what we want.)
>>     
>
> The proposed fix requires coordinated changes in the core and
> pg_standby.  That would be a lot *harder* if pg_standby were external.
> Since we've evidently not gotten this API quite right yet, I think we
> should be keeping pg_standby in contrib until we do, ie the API has been
> stable for awhile ...
>
> 			
>   
Agreed.

Frankly, if anything it should move from contrib to the core proper. I 
regard it as an essential utility, not an optional extra.

cheers

andrew