Message-ID: <4A1C006B.8080600@hagander.net>
Date: Tue, 26 May 2009 16:44:59 +0200
From: Magnus Hagander <magnus@hagander.net>
User-Agent: Thunderbird 2.0.0.21 (X11/20090409)
MIME-Version: 1.0
To: Andrew Dunstan <andrew@dunslane.net>
CC: Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>,
	Josh Berkus <josh@agliodbs.com>,
	Dave Page <dpage@pgadmin.org>, Bruce Momjian <bruce@momjian.us>,
	David Fetter <david@fetter.org>,
	Denis Lussier <denis.lussier@enterprisedb.com>,
	Dimitri Fontaine <dfontaine@hi-media.com>,
	Greg Sabino Mullane <greg@endpoint.com>,
	Greg Smith <gsmith@gregsmith.com>,
	Gregory Stark <stark@enterprisedb.com>, Jan Wieck <JanWieck@Yahoo.com>,
	Joshua Tolley <eggyknap@gmail.com>,
	Koichi Suzuki <koichi.szk@gmail.com>, Marko Kreen <markokr@gmail.com>,
	Michael Meskes <meskes@postgresql.org>,
	Oleg Bartunov <oleg@sai.msu.su>, Peter Eisentraut <peter_e@gmx.net>,
	Robert Haas <robertmhaas@gmail.com>,
	Robert Treat <xzilla@users.sourceforge.net>,
	Selena Deckelmann <selenamarie@gmail.com>,
	Tatsuo Ishii <ishii@sraoss.co.jp>, Teodor Sigaev <teodor@sigaev.ru>,
	Toru SHIMOGAKI <shimogaki.toru@oss.ntt.co.jp>,
	Zdenek Kotala <zdenek.kotala@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PostgreSQL Developer meeting minutes up
References: <937d27e10904270840vaf70c0fr37518478b31d8a15@mail.gmail.com>
	<4A189843.3010200@agliodbs.com>
	<20090524165012.GL8123@tamriel.snowman.net>
	<4A1A52F5.7030009@hagander.net>
	<20090525122821.GO8123@tamriel.snowman.net>
	<4A1BABBC.7070803@hagander.net> <4A1BE039.70008@dunslane.net>
	<10273.1243343651@sss.pgh.pa.us> <4A1BFF70.4000506@dunslane.net>
In-Reply-To: <4A1BFF70.4000506@dunslane.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Andrew Dunstan wrote:
> 
> [moving this onto -hackers, where I think it belongs]
> 
> Tom Lane wrote:
>> Huh?  The buildfarm will only prove that HEAD of the active branches
>> builds.  What the concern was was whether we could correctly extract
>> past states (particularly, but not solely, the tags corresponding to
>> releases) from a converted git repository.  The testing I had in mind
>> was to check out various tags and diff that tree against actual release
>> tarballs.
>>
>>            
>>   
> 
> It appears that our git repo is only picking up the branch tags (e.g.
> REL8_0_STABLE) , not all the release tags (e.g. REL8_0_5) . That needs
> to be fixed (if possible).

Hmm. I looked through the source of the import script. It appears to
mention tags here and there, but doesn't seem to do it. There is a
comment that reads:

      # Previous CVS versions just added the tag to the current HEAD
      # revision and didn't insert a dead revision on the branch with
      # the same date, like it is happening now.
      # This means history is unclear as we can't reliably determine
      # if the tagging happened at the same time as the addition to
      # the branch.  For now, just assume it did.
      #
      # XXX can't reproduce for now, disabling, as it breaks some
      # things
      #


Basically, it comes down to cvs tags not being actual first class
happening, but just metadata on files.

I'm sure we could script the creation of these tags fairly reliably on
*our* repository since we know which files are always updated when a tag
is added. I'm thinking we could just parse the log for configure.in and
grab the tags from there. Thoughts?

-- 
 Magnus Hagander
 Self: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/