Message-ID: <4A2AAA80.9060905@joeconway.com>
Date: Sat, 06 Jun 2009 10:42:24 -0700
From: Joe Conway <mail@joeconway.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.8.0.12) Gecko/20071019 Fedora/1.5.0.12-3.fc6 pango-text
	Thunderbird/1.5.0.12 Mnenhy/0.7.5.666
MIME-Version: 1.0
To: Tom Lane <tgl@sss.pgh.pa.us>
CC: "Hackers (PostgreSQL)" <pgsql-hackers@postgresql.org>
Subject: Re: [Fwd: Re: dblink patches for comment]
References: <4A29E789.1050405@joeconway.com> <10658.1244304503@sss.pgh.pa.us>
In-Reply-To: <10658.1244304503@sss.pgh.pa.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Tom Lane wrote:
> The quoting logic is still completely the wrong thing :-(.  For one
> thing, quote_literal will try to generate E'' syntax in some cases.
> But more to the point, quote_literal's quoting rules don't match
> what is needed.  A look at libpq's conninfo_parse says that what it
> accepts is single-quoted strings in which backslash quotes the next
> character.  It does not recognize doubled single quotes.  I think
> you will need to whip up a special-purpose quoting subroutine.

OK, I see that. I assume I need to care for encoding issues? If so, do I 
assume server encoding or client encoding?


>> + 		return pstrdup(buf->data);
> 
> is a waste of time.  The StringInfo's buffer is already palloc'd.

Thanks -- will fix.

Joe